Fix Dependency violation in L1Trigger/L1THGCalUtilities

[silviodonato]

PR description:

(Similar to #32256)

This PR solves the following dependency errors:

>> Checking dependency for L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc
  ****ERROR: Dependency violation (direct): L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc FastSimulation/Event/interface/FSimTrack.h
  ****ERROR: Dependency violation (direct): L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc FastSimulation/Event/interface/FSimVertex.h
  ****ERROR: Dependency violation (direct): L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc FastSimulation/Event/interface/FBaseSimEvent.h
  ****ERROR: Dependency violation (direct): L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc FastSimulation/Event/interface/FSimVertex.icc
  ****ERROR: Dependency violation (direct): L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc FastSimulation/Event/interface/FSimEvent.h
  ****ERROR: Dependency violation (direct): L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc FastSimulation/Event/interface/FBaseSimEvent.icc
  ****ERROR: Dependency violation (direct): L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc FastSimulation/Event/interface/FSimTrack.icc
>> Done Checking dependency for L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc

See https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc820/CMSSW_11_2_X_2020-11-23-2300/depViolationLogs/L1Trigger/L1THGCalUtilities

PR validation:

I tested ReleaseDepsChecks.pland the errors disappeared after the fix .

[silviodonato]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32257/20023

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10985/console Started: 2020/11/24 14:30

[cmsbuild]

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

L1Trigger/L1THGCalUtilities

@cmsbuild, @rekovic, @kpedro88, @jmduarte can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @jbsauvan, @lgray this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

@cms-sw/core-l2 Both in this PR and in #32256 I'm not sure about the need of moving FastSimulation/Event outside library. Could you confirm this PR is correct? Thank you

[cmsbuild]

+1
Tested at: f97c175
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-efcc16/10985/summary.html
CMSSW: CMSSW_11_2_X_2020-11-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[makortel]

Similarly to #32256 I'm not convinced this change fixes the real dependence violation (but rather confuses the tool)

@smuzaffar Could you comment?

[smuzaffar]

correct @makortel , this is not doing to solve the issue. To fix the issue, L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc should not use L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc/* files or if this is a valid dependencies then we have to whitelist this dep

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-efcc16/10985/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2961011
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960982
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 158 log files, 34 edm output root files, 37 DQM output files

[silviodonato]

Thanks. FastSimulation is currently used in the ntuplizer to take advantage of some FS tools (see https://github.com/cms-sw/cmssw/blob/master/L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc#L181)
The dependency on FastSimulation started with #22387 (@jbsauvan).
I'm not sure if we should either try to fix the code, or remove that piece of code from CMSSW, or keep everything as it is.

[kpedro88]

@silviodonato there's an open issue (for several years now) to move some of that FastSim code into a more common area: #22575

[jbsauvan]

Hello
Sorry for the naive question, but what is exactly this dependency violation? I'm not sure to understand why FS tools couldn't be used in our ntuplizer.

[makortel]

In general L1Trigger packages should not depend on Simulation.

[jbsauvan]

Ok, I understand.
But the L1THGCalUtilities package is actually not containing any L1 trigger emulation code. It is an utility package that isn't used in standard sequences. The core HGCAL trigger code is in L1THGCal.
At the time of the PR mentioned above (#22387), the ntuplizers were in the core L1THGCal package. Since then, the utility package has been created, which is cleaner from the point of view of dependencies.