Fix Dependency violation in muon geometry builders

[silviodonato]

PR description:

This PR solves the following dependency errors:

>> Checking dependency for Geometry/DTGeometryBuilder/plugins/DTGeometryValidate.cc
  ****ERROR: Dependency violation (direct): Geometry/DTGeometryBuilder/plugins/DTGeometryValidate.cc Fireworks/Core/interface/FWGeometry.h
  ****ERROR: Dependency violation (direct): Geometry/DTGeometryBuilder/plugins/DTGeometryValidate.cc Fireworks/Core/interface/FWRecoGeom.h
>> Done Checking dependency for Geometry/DTGeometryBuilder/plugins/DTGeometryValidate.cc
>> Checking dependency for Geometry/GEMGeometryBuilder/plugins/GEMGeometryValidate.cc
  ****ERROR: Dependency violation (direct): Geometry/GEMGeometryBuilder/plugins/GEMGeometryValidate.cc Fireworks/Core/interface/FWGeometry.h
  ****ERROR: Dependency violation (direct): Geometry/GEMGeometryBuilder/plugins/GEMGeometryValidate.cc Fireworks/Core/interface/FWRecoGeom.h
>> Done Checking dependency for Geometry/GEMGeometryBuilder/plugins/GEMGeometryValidate.cc
>> Checking dependency for Geometry/GEMGeometryBuilder/plugins/ME0GeometryValidate.cc
  ****ERROR: Dependency violation (direct): Geometry/GEMGeometryBuilder/plugins/ME0GeometryValidate.cc Fireworks/Core/interface/FWGeometry.h
  ****ERROR: Dependency violation (direct): Geometry/GEMGeometryBuilder/plugins/ME0GeometryValidate.cc Fireworks/Core/interface/FWRecoGeom.h
>> Done Checking dependency for Geometry/GEMGeometryBuilder/plugins/ME0GeometryValidate.cc
>> Checking dependency for Geometry/RPCGeometryBuilder/plugins/RPCGeometryValidate.cc
  ****ERROR: Dependency violation (direct): Geometry/RPCGeometryBuilder/plugins/RPCGeometryValidate.cc Fireworks/Core/interface/FWGeometry.h
  ****ERROR: Dependency violation (direct): Geometry/RPCGeometryBuilder/plugins/RPCGeometryValidate.cc Fireworks/Core/interface/FWRecoGeom.h
>> Done Checking dependency for Geometry/RPCGeometryBuilder/plugins/RPCGeometryValidate.cc
>> Checking dependency for L1Trigger/L1THGCalUtilities/plugins/ntuples/HGCalTriggerNtupleGen.cc

See https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc820/CMSSW_11_2_X_2020-11-23-2300/depViolationLogs/Geometry/CSCGeometryBuilder

PR validation:

I tested ReleaseDepsChecks.pland the errors disappeared after the fix .

[silviodonato]

@cms-sw/externals-l2 actually I'm not sure why we need Fireworks/Core to be outside library

[silviodonato]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32256/20022

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10984/console Started: 2020/11/24 14:05

[cmsbuild]

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Geometry/CSCGeometryBuilder
Geometry/GEMGeometryBuilder
Geometry/RPCGeometryBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@watson-ij, @jshlee, @ptcox, @dildick, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 727a6f3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e7468/10984/summary.html
CMSSW: CMSSW_11_2_X_2020-11-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[makortel]

I'm a bit confused how exactly moving the use declaration from a <library> element to the "top level" of the BuildFile.xml helps to remove the dependence (my understanding is that all declared libraries will depend on the top level dependencies).

I'm also confused what exactly is being violated here. Geometry package depending on Fireworks package?

[silviodonato]

Thanks @makortel , the origin of the dependency is here

cmssw/Geometry/CSCGeometryBuilder/plugins/CSCGeometryValidate.cc

Line 27 in 727a6f3

#include "Fireworks/Core/interface/FWGeometry.h"

It was introduced with #29111. @slomeo would it be possible to remove the dependency on Fireworks in CSCGeometryValidate.cc?

I'm a bit confused how exactly moving the use declaration from a element to the "top level" of the BuildFile.xml helps to remove the dependence (my understanding is that all declared libraries will depend on the top level dependencies).

I'm confused as well, it might be just a bug of ReleaseDepsChecks.pl

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e7468/10984/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2961011
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960982
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 158 log files, 34 edm output root files, 37 DQM output files