Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HGCAL trigger updates (including new 2D clustering + towers implementation) #22387

Merged
merged 73 commits into from
Mar 10, 2018
Merged

HGCAL trigger updates (including new 2D clustering + towers implementation) #22387

merged 73 commits into from
Mar 10, 2018

Conversation

jbsauvan
Copy link
Contributor

This PR adds the following changes for the HGCAL trigger:

  • Implementation of a new 2D clustering algorithm, similar to the previous topological algorithm, but with size constrained
  • Implementation of tower objects in addition to cluster objects
  • Move the cluster energy calibration from 3D clusters to 2D clusters
  • Ntuple updates: additional information in gen ntuple; new panel-level information

Depends on external cms-data/L1Trigger-L1THGCal#6

jbsauvan and others added 30 commits November 23, 2017 10:16
@jbsauvan
Add panel ntuple
0854268
This is adding a new clustering method. It consists in a combined dR…
4bc81f6 
…+NN algorithm.
@jbsauvan
Update panel ntuple
d3186b8
@jbsauvan
Add TDR-like panel geometry
d7bb2ad
@jbsauvan
Add calibration of sim energies in ntuples and update TC calib coeffs…
7951a79 
… with half layers
Update of the new geoNN 2D cluster algorithm. All the pieces are in p…
0ec2e5b 
…lace. Still 2 points need to be fixed: sorting the tc using vector::sort and check if seeds are NN.
C2D geoNN is updated and seeds are treated in order to avoid NN seeds…
406a126 
… starting 2 different clusters.
NN-geo clustering: sorting of the distance vector done using std::sort()
e0d24df
All comments implemnted except the PtrVector to be replaces with vect…
6abf4c9 
…or<Ptr>
edm::PtrVector<C> has been replaces with std::vector<edm::Ptr<C>>
aeee613
Few style fixes
51c2dd1
@jbsauvan
Fix simhit calibration
149d811
@jbsauvan
Reduce TC threshold in frontend
d6f4fc9
Indentation fixed in DataFormats/L1THGCal/interface/HGCalClusterT.h; …
f4380d8 
…dRNNC2D method is set as not the default
@jbsauvan
Merge pull request #164 from vpalladi/c2d-dev
59b51f4 
 This is adding a new clustering method. It consists in a combined dR…
@jbsauvan
Merge branch 'PFCal-dev/hgc-tpg-devel-CMSSW_9_4_0_pre2' into cc-trigg…
3f9d459 
…er-sel-study
@jbsauvan
Cleaning
71e7774
@tstreble
Fix of dRNNC2d
df242f2
@jbsauvan
Merge pull request #165 from jbsauvan/cc-trigger-sel-study
d4d3974 
Panel layout and ntuples updates
@jbsauvan
Merge pull request #166 from tstreble/dRNNC2d_update
8edfa4e 
Fix of dRNNC2d
@jbsauvan
Use TDR panel layout as default
33cc5d4
@jbsauvan
Merge pull request #169 from jbsauvan/default-panel-tdr-layout
1b02868 
Use TDR panel layout as default
@jbsauvan
Fix custom geometries
28a5ab0
@jbsauvan
Merge pull request #172 from jbsauvan/fix-custom-geom
584abd2 
Fix custom geometries
@cerminar
add quick and dirty implementation of a tool suite, currently mainly …
6d348b1 
…for layer counting independent on the subdet
@cerminar
make the layer count independent on the subdet
9e6a9b0
@cerminar
make the layer count independent on the subdet
7d1f68a
@cerminar
cleanup
166c705
@cerminar
switch on sim info
454d8d7
@cerminar
move to the trigger geometry to compute the position. This needs some…
c011498 
… care....
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

+1
Tested at: 764c79b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22387/26658/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a787a94
99cea22
e88d8ce
3f4e93a
85741b6
12960a4
5dd214f
178fff5
e8d1163
584abd2
1b02868
8edfa4e
d4d3974
3f9d459
59b51f4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22387/26658/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22387/26658/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22387/26658/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2480211
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2480034
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.980000000069 KiB( 22 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Mar 7, 2018

+1

@rekovic
Copy link
Contributor

rekovic commented Mar 7, 2018

Following comment in #22480, added HGCalTowerMap in the event content.

@jbsauvan Thanks.

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 7, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 9, 2018

@fabiocos can you merge this so it can run in a few IBs over the weekend? Then we can finalize the next 93X release.

@kpedro88 kpedro88 mentioned this pull request Mar 9, 2018
Closed
@fabiocos
Copy link
Contributor

@kpedro88 the issue of the FastSim dependency has not been addressed in the PR. I understand the need of moving forward with tests, but this will have to be looked at.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d07040b into cms-sw:master Mar 10, 2018
@kpedro88 kpedro88 mentioned this pull request Mar 10, 2018
Open
@kpedro88
Copy link
Contributor

@fabiocos posted #22575 to keep track of this.

@fabiocos
Copy link
Contributor

@kpedro88 thanks

@silviodonato silviodonato mentioned this pull request Nov 24, 2020
Closed
@jbsauvan jbsauvan mentioned this pull request Nov 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpedro88 kpedro88 kpedro88 left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed l1-approved orp-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_10_1_X
Development

Successfully merging this pull request may close these issues.
10 participants
@jbsauvan @cmsbuild @kpedro88 @rekovic @smuzaffar @davidlange6 @thomreis @fabiocos @tstreble @cerminar