Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HGCAL trigger updates (including new 2D clustering + towers implementation) #22387

Merged
merged 73 commits into from
Mar 10, 2018
Merged

HGCAL trigger updates (including new 2D clustering + towers implementation) #22387

merged 73 commits into from
Mar 10, 2018

Commits on Nov 23, 2017

  1. Add panel ntuple

    @jbsauvan
    jbsauvan committed Nov 23, 2017
    Configuration menu
    Copy the full SHA
    0854268 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2017

  1. This is adding a new clustering method. It consists in a combined dR… 

    …+NN algorithm.
    vpalladi committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    4bc81f6 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2017

  1. Update panel ntuple

    @jbsauvan
    jbsauvan committed Dec 6, 2017
    Configuration menu
    Copy the full SHA
    d3186b8 View commit details
    Browse the repository at this point in the history

  2. Add TDR-like panel geometry

    @jbsauvan
    jbsauvan committed Dec 6, 2017
    Configuration menu
    Copy the full SHA
    d7bb2ad View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2017

  1. Add calibration of sim energies in ntuples and update TC calib coeffs… 

    … with half layers
    @jbsauvan
    jbsauvan committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    7951a79 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2017

  1. Update of the new geoNN 2D cluster algorithm. All the pieces are in p… 

    …lace. Still 2 points need to be fixed: sorting the tc using vector::sort and check if seeds are NN.
    vpalladi committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    0ec2e5b View commit details
    Browse the repository at this point in the history

  2. C2D geoNN is updated and seeds are treated in order to avoid NN seeds… 

    … starting 2 different clusters.
    vpalladi committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    406a126 View commit details
    Browse the repository at this point in the history

  3. NN-geo clustering: sorting of the distance vector done using std::sort()

    vpalladi committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    e0d24df View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2017

  1. All comments implemnted except the PtrVector to be replaces with vect… 

    …or<Ptr>
    vpalladi committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    6abf4c9 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2017

  1. edm::PtrVector<C> has been replaces with std::vector<edm::Ptr<C>>

    vpalladi committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    aeee613 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2017

  1. Few style fixes

    vpalladi committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    51c2dd1 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2017

  1. Fix simhit calibration

    @jbsauvan
    jbsauvan committed Dec 16, 2017
    Configuration menu
    Copy the full SHA
    149d811 View commit details
    Browse the repository at this point in the history

  2. Reduce TC threshold in frontend

    @jbsauvan
    jbsauvan committed Dec 16, 2017
    Configuration menu
    Copy the full SHA
    d6f4fc9 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2017

  1. Indentation fixed in DataFormats/L1THGCal/interface/HGCalClusterT.h; … 

    …dRNNC2D method is set as not the default
    vpalladi committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    f4380d8 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #164 from vpalladi/c2d-dev 

     This is adding a new clustering method. It consists in a combined dR…
    @jbsauvan
    jbsauvan authored Dec 18, 2017
    Configuration menu
    Copy the full SHA
    59b51f4 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2018

  1. Merge branch 'PFCal-dev/hgc-tpg-devel-CMSSW_9_4_0_pre2' into cc-trigg… 

    …er-sel-study
    @jbsauvan
    jbsauvan committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    3f9d459 View commit details
    Browse the repository at this point in the history

  2. Cleaning

    @jbsauvan
    jbsauvan committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    71e7774 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2018

  1. Fix of dRNNC2d

    @tstreble
    tstreble committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    df242f2 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2018

  1. Merge pull request #165 from jbsauvan/cc-trigger-sel-study 

    Panel layout and ntuples updates
    @jbsauvan
    jbsauvan authored Jan 14, 2018
    Configuration menu
    Copy the full SHA
    d4d3974 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2018

  1. Merge pull request #166 from tstreble/dRNNC2d_update 

    Fix of dRNNC2d
    @jbsauvan
    jbsauvan authored Jan 15, 2018
    Configuration menu
    Copy the full SHA
    8edfa4e View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. Use TDR panel layout as default

    @jbsauvan
    jbsauvan committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    33cc5d4 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #169 from jbsauvan/default-panel-tdr-layout 

    Use TDR panel layout as default
    @jbsauvan
    jbsauvan authored Jan 16, 2018
    Configuration menu
    Copy the full SHA
    1b02868 View commit details
    Browse the repository at this point in the history

  3. Fix custom geometries

    @jbsauvan
    jbsauvan committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    28a5ab0 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #172 from jbsauvan/fix-custom-geom 

    Fix custom geometries
    @jbsauvan
    jbsauvan authored Jan 16, 2018
    Configuration menu
    Copy the full SHA
    584abd2 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2018

  1. add quick and dirty implementation of a tool suite, currently mainly … 

    …for layer counting independent on the subdet
    @cerminar
    cerminar committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    6d348b1 View commit details
    Browse the repository at this point in the history

  2. make the layer count independent on the subdet

    @cerminar
    cerminar committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    9e6a9b0 View commit details
    Browse the repository at this point in the history

  3. make the layer count independent on the subdet

    @cerminar
    cerminar committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    7d1f68a View commit details
    Browse the repository at this point in the history

  4. cleanup

    @cerminar
    cerminar committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    166c705 View commit details
    Browse the repository at this point in the history

  5. switch on sim info

    @cerminar
    cerminar committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    454d8d7 View commit details
    Browse the repository at this point in the history

  6. move to the trigger geometry to compute the position. This needs some… 

    … care....
    @cerminar
    cerminar committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    c011498 View commit details
    Browse the repository at this point in the history

  7. expand gen information borrowing the code from CMS-HGCAL/reco-ntuples… 

    … repo
    @cerminar
    cerminar committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    fb3d571 View commit details
    Browse the repository at this point in the history

  8. support for the new GEN module

    @cerminar
    cerminar committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    c6c076e View commit details
    Browse the repository at this point in the history

  9. adapt the python config to the new GEN module functionality

    @cerminar
    cerminar committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    c8c7a7b View commit details
    Browse the repository at this point in the history

  10. small fixes after merging conflicts

    @cerminar
    cerminar committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    ae3f772 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2018

  1. Fix of dRNNC2D 

    Fix for dRNNC2D (to get C2Ds with more than one cell)
    @tstreble
    tstreble authored Jan 22, 2018
    Configuration menu
    Copy the full SHA
    398f593 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2018

  1. Merge pull request #176 from tstreble/dRNNC2d_update 

    dRNNC2D update
    @jbsauvan
    jbsauvan authored Jan 23, 2018
    Configuration menu
    Copy the full SHA
    e8d1163 View commit details
    Browse the repository at this point in the history

  2. make the interface more clear about the fact that some of the methods… 

    … are meant for TCs only. Add some functionality for layer positions
    @cerminar
    cerminar committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    a1ce640 View commit details
    Browse the repository at this point in the history

  3. cosmetics + new more consistent way to retrieve layer z positions

    @cerminar
    cerminar committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    607eb79 View commit details
    Browse the repository at this point in the history

  4. change name of particle filter and switch some defaults

    @cerminar
    cerminar committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    9d2421e View commit details
    Browse the repository at this point in the history

  5. cleanup

    @cerminar
    cerminar committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    f467df2 View commit details
    Browse the repository at this point in the history

  6. Move cluster calibration to the C2Ds

    @tstreble
    tstreble committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    a99a0b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2018

  1. Cosmetic changes

    @tstreble
    tstreble committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    529b1f8 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. Merge pull request #177 from tstreble/HGC_C2D_calibr 

    HGC C2D calibration
    @jbsauvan
    jbsauvan authored Jan 25, 2018
    Configuration menu
    Copy the full SHA
    178fff5 View commit details
    Browse the repository at this point in the history

  2. more explicit names to remove magic

    @cerminar
    cerminar committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    3062cef View commit details
    Browse the repository at this point in the history

  3. Merge pull request #175 from cerminar/gc_dev_01_94X 

    Expand GEN level information and prototype tool to handle TC geometry related info
    @jbsauvan
    jbsauvan authored Jan 25, 2018
    Configuration menu
    Copy the full SHA
    5dd214f View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2018

  1. Add clustering and calibration customization functions

    @jbsauvan
    jbsauvan committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    aa74213 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2018

  1. Merge pull request #181 from jbsauvan/config-defaults 

    Add clustering and calibration customization functions
    @jbsauvan
    jbsauvan authored Feb 12, 2018
    Configuration menu
    Copy the full SHA
    12960a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2018

  1. Merged hgc-tpg-devel-CMSSW_9_4_0_pre2 from repository PFCal-dev with … 

    …cms-merge-topic
    @tstreble
    tstreble committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    85741b6 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. New implementation of HGC towers

    @tstreble
    tstreble committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    b555619 View commit details
    Browse the repository at this point in the history

  2. Fixed alignement

    @tstreble
    tstreble committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    b14aa22 View commit details
    Browse the repository at this point in the history

  3. Updated eta range for warning in HGC towers

    @tstreble
    tstreble committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    aa0d156 View commit details
    Browse the repository at this point in the history

  4. Fix for 2D tower maps

    @tstreble
    tstreble committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    d678efe View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2018

  1. Fix shower shape filling with DBSCAN

    @jbsauvan
    jbsauvan committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    97403fc View commit details
    Browse the repository at this point in the history

  2. Add exception if calib coeff = 0 applied

    @jbsauvan
    jbsauvan committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    1e84db6 View commit details
    Browse the repository at this point in the history

  3. Improvements of HGC TowerMaps

    @tstreble
    tstreble committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    dc6c300 View commit details
    Browse the repository at this point in the history

  4. Cleaning

    @tstreble
    tstreble committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    774a4f0 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2018

  1. Merge pull request #182 from tstreble/L1THGC_TowerMaps_2.0 

    L1T HGC towers
    @jbsauvan
    jbsauvan authored Feb 23, 2018
    Configuration menu
    Copy the full SHA
    3f4e93a View commit details
    Browse the repository at this point in the history

  2. Merged hgc-tpg-devel-CMSSW_9_4_0_pre2 from repository PFCal-dev with … 

    …cms-merge-topic
    @jbsauvan
    jbsauvan committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    e88d8ce View commit details
    Browse the repository at this point in the history

  3. Post 10_1_X merging fixes

    @jbsauvan
    jbsauvan committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    1edf95b View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. cleaning

    @jbsauvan
    jbsauvan committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    620f898 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2018

  1. Fix constness

    @jbsauvan
    jbsauvan committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    a881c1d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #187 from jbsauvan/cleaning 

    Cleaning
    @jbsauvan
    jbsauvan authored Feb 28, 2018
    Configuration menu
    Copy the full SHA
    99cea22 View commit details
    Browse the repository at this point in the history

  3. Remove TDR panel mapping from data

    @jbsauvan
    jbsauvan committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    b570b5a View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2018

  1. Use hash table instead of vector to store cluster constituents

    @jbsauvan
    jbsauvan committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    658743f View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. cleaning

    @jbsauvan
    jbsauvan committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    84dfff8 View commit details
    Browse the repository at this point in the history

  2. Use configurable input tags

    @jbsauvan
    jbsauvan committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    3affe2a View commit details
    Browse the repository at this point in the history

  3. Use ESWatchers in gen ntuplizer

    @jbsauvan
    jbsauvan committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    625c55e View commit details
    Browse the repository at this point in the history

  4. Remove hardcoded variables

    @jbsauvan
    jbsauvan committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    c3f8207 View commit details
    Browse the repository at this point in the history

  5. Switch back default clustering in test cfg

    @jbsauvan
    jbsauvan committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    5bf06db View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2018

  1. Add HGCAL TPG in standard sequences

    @jbsauvan
    jbsauvan committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    e3a1c3b View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Merge branch 'master' into hgc-tpg-integration-180228

    @jbsauvan
    jbsauvan authored Mar 5, 2018
    Configuration menu
    Copy the full SHA
    a787a94 View commit details
    Browse the repository at this point in the history

  2. Apply code checks

    @jbsauvan
    jbsauvan committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    5b5339b View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2018

  1. Add layer tower maps in event

    @jbsauvan
    jbsauvan committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    764c79b View commit details
    Browse the repository at this point in the history