Clean BuildFiles in L1Trigger #31548
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31548/18558
|
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: L1Trigger/CSCCommonTrigger @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Hi Jonas, there a few packages that I maintain within the L1-trigger. What prevents |
|
Hello Sven! I would like to give you an answer, but I don't really understand the question. Are you wondering why the changes that I suggest in this PR are not just suggested by the code checks? All I can say is that I intended to improve the modularity of CMSSW with these PRs. My original motivation was that I wanted to build parts of CMSSW independently of the rest, and on the way I wrote a script that removes unused dependencies from the BuildFiles. In the last year, I occasionally made PRs for different subsystems after running the script, and L1Trigger is actually the only remaining subsystem for which I didn't make a PR so far. However, when you automatically remove the unused dependencies like that, you occasionally break packages that didn't declare all their dependencies but relied on the unused dependency declarations in packages further up in the dependency hierarchy that are now removed. That's why this PR also adds a few lines. |
|
I think you largely answered my question. Thanks! In the future though, if someone were to (accidentally) remove a |
|
If someone would accidentally remove a My script is too inefficient and not flexible enough to consider using it with scram; it's really more of a one-shot thing to get rid of a massive amount of unused dependencies that have accumulated over the years. |
|
Ok. Thanks. |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+upgrade |
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #31532).
As always, only the dependencies which are not included in any of the sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included.
PR validation:
CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with
git grep.