Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test failure in DQM/Integration (issue 31592) #31593

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Fix unit test failure in DQM/Integration (issue 31592) #31593

merged 1 commit into from
Sep 29, 2020

Conversation

guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Sep 26, 2020

PR description:

An issue (#31592) appeared after the most recent BuilFile cleaning PR (#31548).

I guess the problem is that the BuildFile declares a normal library instead of an EDM plugin library, so that's what I suggest to change in this PR (inspired by [1]). Before my cleaning PR, this library was linked against by some other plugin, and that's how the plugin got registered in the past [2].

Now, the plugin can be found again with edmPluginHelp -p L1GtTriggerMaskTechTrigTrivialProducer and the previously-failing unit test succeeds.

[1] https://github.com/cms-sw/cmssw/blob/master/RecoEgamma/EgammaPhotonProducers/BuildFile.xml
[2] https://github.com/cms-sw/cmssw/pull/31548/files#diff-d35b5dbd3e30c40bee4cc0c5bd6ae022L13

PR validation:

  • the L1GtTriggerMaskTechTrigTrivialProducer can be found once again with edmPluginHelp
  • unit test ./src/DQM/Integration/test/runtest.sh scal_dqm_sourceclient-live_cfg.py passes again

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31593/18647

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

L1TriggerConfig/L1GtConfigProducers

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

test parameters:
addpkg = DQM/Integration

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 28, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 4db194f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef84fe/9605/summary.html
CMSSW: CMSSW_11_2_X_2020-09-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@silviodonato
Copy link
Contributor

+1
Tested at: 4db194f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef84fe/9605/summary.html
CMSSW: CMSSW_11_2_X_2020-09-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

---> test TestDQMOnlineClient-sistrip_dqm_sourceclient succeeded

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef84fe/9605/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2539438
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2539415
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Sep 28, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 29, 2020

+1

@cmsbuild cmsbuild merged commit 27f7705 into cms-sw:master Sep 29, 2020
@guitargeek guitargeek deleted the issue_31592 branch September 29, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants