Absorb CSCCommonTrigger into CSCTriggerPrimitives #31549

dildick · 2020-09-23T04:09:21Z

PR description:

CSCCommonTrigger contains a number of unused files: vmac.h, vlib.h, vlib.cc, CSCFrontRearLUT.h with sole function getFRBit. I don't see getFRBit in the index anywhere. CSCPatternLUT.h should actually be in CSCTriggerPrimitives (in CSCPatternBank.h). If you remove the unused files and move CSCPatternLUT you realize that this package really only contains a single python file with the MPC LCT BX accept window, which might as well be in CSCTriggerPrimitives/python. I propose to absorb CSCCommonTrigger in CSCTriggerPrimitives.

See also #31505 that mentions unused headers in CSCCommonTrigger.

PR validation:

Code compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

cmsbuild · 2020-09-23T04:09:48Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-23T04:16:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31549/18561

This PR adds an extra 88KB to repository
Found files with invalid states:
- L1Trigger/CSCTriggerPrimitives/interface/CSCPatternLUT.h:
  - Added: 4b11554
  - Deleted: e78febb
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/CSCCommonTrigger/BuildFile.xml modified in PR(s): Clean BuildFiles in L1Trigger #31548
- File L1Trigger/CSCTrackFinder/BuildFile.xml modified in PR(s): Clean BuildFiles in L1Trigger #31548
- File L1Trigger/CSCTrackFinder/test/BuildFile.xml modified in PR(s): Clean BuildFiles in L1Trigger #31548
- File L1Trigger/CSCTriggerPrimitives/BuildFile.xml modified in PR(s): Clean BuildFiles in L1Trigger #31548
- File L1Trigger/CSCTriggerPrimitives/README.md modified in PR(s): Remove option to run on single GEM pads; Simplify CSC trigger configuration #31460
- File L1Trigger/CSCTriggerPrimitives/plugins/BuildFile.xml modified in PR(s): Clean BuildFiles in L1Trigger #31548
- File L1Trigger/CSCTriggerPrimitives/python/cscTriggerPrimitiveDigis_cfi.py modified in PR(s): Remove option to run on single GEM pads; Simplify CSC trigger configuration #31460
- File L1Trigger/CSCTriggerPrimitives/test/macros/CCLUTLinearFitWriter.cpp modified in PR(s): Remove option to run on single GEM pads; Simplify CSC trigger configuration #31460
- File L1Trigger/L1TMuon/BuildFile.xml modified in PR(s): Clean BuildFiles in L1Trigger #31548
- File L1Trigger/L1TMuon/python/simDigis_cff.py modified in PR(s): Initial Changes for Incoporating GEM GE0 into the Reco Pipeline #31309

cmsbuild · 2020-09-23T04:17:12Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DQM/L1TMonitor
EventFilter/CSCTFRawToDigi
L1Trigger/CSCCommonTrigger
L1Trigger/CSCTrackFinder
L1Trigger/CSCTriggerPrimitives
L1Trigger/Configuration
L1Trigger/L1TMuon
L1Trigger/L1TMuonEndCap
L1Trigger/L1TMuonOverlap
Utilities/ReleaseScripts

@smuzaffar, @benkrikler, @Dr15Jones, @makortel, @andrius-k, @ErnestaP, @cmsbuild, @rekovic, @jfernan2, @kmaeshima, @fioriNTU can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ptcox, @valuev, @thomreis, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2020-09-23T07:31:44Z

please test

cmsbuild · 2020-09-23T07:32:07Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-22-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9511/console Started: 2020/09/23 09:32

cmsbuild · 2020-09-23T08:56:40Z

+1
Tested at: e78febb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73e8ff/9511/summary.html
CMSSW: CMSSW_11_2_X_2020-09-22-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-23T08:56:42Z

Comparison job queued.

cmsbuild · 2020-09-23T10:24:20Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73e8ff/9511/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2540471
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2540448
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

jfernan2 · 2020-09-23T10:42:03Z

+1

dildick · 2020-09-24T16:24:02Z

@Dr15Jones Are you ok with this proposal? I need a core member to sign off on this PR.

silviodonato · 2020-09-29T07:43:32Z

L1Trigger/L1THGCal/data/panel_mapping_V11_decentralized_march20_2.txt was pointed by #31524 and added with cms-data/L1Trigger-L1THGCal#20.
Probably, the test included #31524 without including the external cms-data/L1Trigger-L1THGCal#20.
Let's try again

silviodonato · 2020-09-29T07:43:40Z

please test

cmsbuild · 2020-09-29T07:44:00Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-28-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9636/console Started: 2020/09/29 09:45

cmsbuild · 2020-09-29T09:12:05Z

+1
Tested at: 850f2b0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73e8ff/9636/summary.html
CMSSW: CMSSW_11_2_X_2020-09-28-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-29T09:12:08Z

Comparison job queued.

cmsbuild · 2020-09-29T10:44:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73e8ff/9636/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2539438
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2539409
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

makortel · 2020-09-29T12:52:41Z

+1

jfernan2 · 2020-09-29T14:16:48Z

+1

silviodonato · 2020-09-29T14:17:43Z

kind reminder @cms-sw/l1-l2

dildick · 2020-09-30T15:30:14Z

@silviodonato Can this be merged?

silviodonato · 2020-09-30T15:41:33Z

merge
@rekovic already signed an older version

cmsbuild added this to the CMSSW_11_2_X milestone Sep 23, 2020

cmsbuild added code-checks-pending comparison-pending core-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels Sep 23, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 23, 2020

cmsbuild mentioned this pull request Sep 23, 2020

Initial Changes for Incoporating GEM GE0 into the Reco Pipeline #31309

Merged

cmsbuild added tests-started and removed tests-pending labels Sep 23, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 23, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 23, 2020

cmsbuild added dqm-approved and removed dqm-pending labels Sep 23, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Sep 29, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 29, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 29, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 29, 2020

cmsbuild added core-approved and removed core-pending labels Sep 29, 2020

cmsbuild added dqm-approved and removed dqm-pending labels Sep 29, 2020

cmsbuild mentioned this pull request Sep 30, 2020

Remove option to run on single GEM pads; Simplify CSC trigger configuration #31631

Merged

cmsbuild added orp-approved and removed orp-pending labels Sep 30, 2020

cmsbuild merged commit 57acfe5 into cms-sw:master Sep 30, 2020

dildick deleted the from-CMSSW_11_2_X_2020-09-22-1100-CSCCommonTrigger-cleanup branch October 13, 2020 17:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Absorb CSCCommonTrigger into CSCTriggerPrimitives #31549

Absorb CSCCommonTrigger into CSCTriggerPrimitives #31549

dildick commented Sep 23, 2020 •

edited

Loading

cmsbuild commented Sep 23, 2020

cmsbuild commented Sep 23, 2020

cmsbuild commented Sep 23, 2020

jfernan2 commented Sep 23, 2020

cmsbuild commented Sep 23, 2020 •

edited

Loading

cmsbuild commented Sep 23, 2020

cmsbuild commented Sep 23, 2020

cmsbuild commented Sep 23, 2020

jfernan2 commented Sep 23, 2020

dildick commented Sep 24, 2020

silviodonato commented Sep 29, 2020

silviodonato commented Sep 29, 2020

cmsbuild commented Sep 29, 2020 •

edited

Loading

cmsbuild commented Sep 29, 2020

cmsbuild commented Sep 29, 2020

cmsbuild commented Sep 29, 2020

makortel commented Sep 29, 2020

jfernan2 commented Sep 29, 2020

silviodonato commented Sep 29, 2020

dildick commented Sep 30, 2020

silviodonato commented Sep 30, 2020

Absorb CSCCommonTrigger into CSCTriggerPrimitives #31549

Absorb CSCCommonTrigger into CSCTriggerPrimitives #31549

Conversation

dildick commented Sep 23, 2020 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Sep 23, 2020

cmsbuild commented Sep 23, 2020

cmsbuild commented Sep 23, 2020

jfernan2 commented Sep 23, 2020

cmsbuild commented Sep 23, 2020 • edited Loading

cmsbuild commented Sep 23, 2020

cmsbuild commented Sep 23, 2020

cmsbuild commented Sep 23, 2020

jfernan2 commented Sep 23, 2020

dildick commented Sep 24, 2020

silviodonato commented Sep 29, 2020

silviodonato commented Sep 29, 2020

cmsbuild commented Sep 29, 2020 • edited Loading

cmsbuild commented Sep 29, 2020

cmsbuild commented Sep 29, 2020

cmsbuild commented Sep 29, 2020

makortel commented Sep 29, 2020

jfernan2 commented Sep 29, 2020

silviodonato commented Sep 29, 2020

dildick commented Sep 30, 2020

silviodonato commented Sep 30, 2020

dildick commented Sep 23, 2020 •

edited

Loading

cmsbuild commented Sep 23, 2020 •

edited

Loading

cmsbuild commented Sep 29, 2020 •

edited

Loading