Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable double migration test #1023

Merged
merged 1 commit into from
Jun 29, 2023
Merged

fix: Enable double migration test #1023

merged 1 commit into from
Jun 29, 2023

Conversation

candiduslynx
Copy link
Contributor

Summary


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests πŸ§ͺ
  • Ensure the status checks below are successful βœ…

@github-actions
Copy link

⏱️ Benchmark results

Comparing with 46a9b31

  • Glob-2 ns/op: 199.8 ⬇️ 10.91% decrease vs. 46a9b31

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 πŸŽ‰

Comparison is base (46a9b31) 48.24% compared to head (78cc5fa) 48.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
+ Coverage   48.24%   48.28%   +0.04%     
==========================================
  Files          76       76              
  Lines        7417     7417              
==========================================
+ Hits         3578     3581       +3     
+ Misses       3507     3505       -2     
+ Partials      332      331       -1     
Impacted Files Coverage Ξ”
plugin/testing_write_migrate.go 0.00% <0.00%> (ΓΈ)

... and 1 file with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@kodiakhq kodiakhq bot merged commit 466796b into main Jun 29, 2023
7 checks passed
@kodiakhq kodiakhq bot deleted the candiduslynx-patch-1 branch June 29, 2023 19:40
kodiakhq bot pushed a commit that referenced this pull request Jun 29, 2023
πŸ€– I have created a release *beep* *boop*
---


## [4.3.1-rc1](v4.3.0-rc1...v4.3.1-rc1) (2023-06-29)


### Bug Fixes

* Enable double migration test ([#1023](#1023)) ([466796b](466796b))
* Put null helpers back ([#1002](#1002)) ([95ed5df](95ed5df))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants