Skip to content

Commit

Permalink
fix: Enable double migration test (#1023)
Browse files Browse the repository at this point in the history


<!--
Explain what problem this PR addresses
-->

---
  • Loading branch information
candiduslynx committed Jun 29, 2023
1 parent 46a9b31 commit 466796b
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions plugin/testing_write_migrate.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"github.com/cloudquery/plugin-sdk/v4/schema"
"github.com/cloudquery/plugin-sdk/v4/types"
"github.com/google/uuid"
"github.com/stretchr/testify/require"
)

func tableUUIDSuffix() string {
Expand Down Expand Up @@ -210,9 +211,9 @@ func (s *WriterTestSuite) testMigrate(
})

t.Run("double_migration", func(t *testing.T) {
// tableName := "double_migration_" + tableUUIDSuffix()
// table := schema.TestTable(tableName, testOpts.TestSourceOptions)
// require.NoError(t, p.Migrate(ctx, schema.Tables{table}, MigrateOptions{MigrateMode: MigrateModeForce}))
// require.NoError(t, p.Migrate(ctx, schema.Tables{table}, MigrateOptions{MigrateMode: MigrateModeForce}))
tableName := "double_migration_" + tableUUIDSuffix()
table := schema.TestTable(tableName, s.genDatOptions)
// s.migrate will perform create->write->migrate->write
require.NoError(t, s.migrate(ctx, table, table, true, false))
})
}

1 comment on commit 466796b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Benchmark results

  • Glob-2 ns/op: 201.2

Please sign in to comment.