Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to keep rb-fsevent version in sync. #2637

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Conversation

vkarve-chef
Copy link
Collaborator

Description

If the rb-fsevent gem version noted in components/gems/Gemfile.lock is older than the HEAD of master branch in the repo referred in omnibus/config/software/rb-fsevent-gem.rb, then this results in a pre-compiled bundle plus recompiled bundle getting packaged in Chef Workstation. Some commands fail on MacOS.

This is an attempt to maintain static reference to commit corresponding to the version noted in Gemfile.lock.

Related Issue

#2580

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@vkarve-chef vkarve-chef added the Expeditor: Skip All Used to skip all merge_actions. label Mar 7, 2022
@vkarve-chef vkarve-chef requested review from a team as code owners March 7, 2022 15:43
@netlify
Copy link

netlify bot commented Mar 7, 2022

👷 Deploy Preview for chef-workstation processing.

🔨 Explore the source changes: a343948

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-workstation/deploys/622887a15ce3a40008082c60

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

Simplecov Report

Covered Threshold
79.33% 79%

Signed-off-by: Vikram Karve <vikram.karve@progress.com>
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
@vkarve-chef vkarve-chef merged commit 5a00fcd into main Mar 9, 2022
@vkarve-chef vkarve-chef deleted the vkarve/sync-rb-fsevent branch March 9, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expeditor: Skip All Used to skip all merge_actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants