Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes notarize error #2580

Merged
merged 7 commits into from
Feb 10, 2022
Merged

Fixes notarize error #2580

merged 7 commits into from
Feb 10, 2022

Conversation

vkarve-chef
Copy link
Collaborator

Description

The omnibus based build was failing at Notarize step applicable to Mac packages. This was due to a redundant version of rb-fsevent gem getting bundled in the package. The rb-fsevent-gem.rb script fetches latest version from source while the Gemfile.lock had the version pinned to an older version.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@vkarve-chef vkarve-chef requested review from a team as code owners February 10, 2022 18:49
@netlify
Copy link

netlify bot commented Feb 10, 2022

👷 Deploy Preview for chef-workstation processing.

🔨 Explore the source changes: a0a5890

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-workstation/deploys/62055e496b6a7f0007a134b9

nikhil2611 and others added 7 commits February 10, 2022 18:49
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
…em.rb

Signed-off-by: Vikram Karve <vikram.karve@progress.com>
@github-actions
Copy link

Simplecov Report

Covered Threshold
79.33% 79%

@vkarve-chef vkarve-chef merged commit 565d3a9 into main Feb 10, 2022
@vkarve-chef vkarve-chef deleted the nikhil/rb-fsevent-issue branch February 10, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants