Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rb-fsevent SHA in sync with updated version in Gemfile #2923

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Update rb-fsevent SHA in sync with updated version in Gemfile #2923

merged 1 commit into from
Sep 13, 2022

Conversation

vkarve-chef
Copy link
Collaborator

@vkarve-chef vkarve-chef commented Sep 13, 2022 •
edited
Loading

Signed-off-by: Vikram Karve vikram.karve@progress.com

Description

Need to manually update rb-fsevent commit hash to match version specified in Gemfile, to avoid notarize error. The rb-fsevent version got bumped in #2919

Related Issue

Related to #2637

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@vkarve-chef
Update rb-fsevent SHA in sync with updated version in Gemfile
3bd5556 
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
@vkarve-chef vkarve-chef requested review from a team as code owners September 13, 2022 11:46
@vkarve-chef vkarve-chef added the Expeditor: Skip All Used to skip all merge_actions. label Sep 13, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Simplecov Report

Covered Threshold
79.33% 79%

@netlify
Copy link

netlify bot commented Sep 13, 2022

✅ Deploy Preview for chef-workstation canceled.

Name Link
🔨 Latest commit 3bd5556
🔍 Latest deploy log https://app.netlify.com/sites/chef-workstation/deploys/63206dadc64a510009c8455c

@vkarve-chef vkarve-chef merged commit 3e1b6a1 into main Sep 13, 2022
@vkarve-chef vkarve-chef deleted the vkarve/fix-fsevent-version branch September 13, 2022 16:10
vkarve-chef added a commit that referenced this pull request Sep 27, 2022
@vkarve-chef
Update rb-fsevent SHA in sync with updated version in Gemfile (#2923)
77c0b0f 
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
(cherry picked from commit 3e1b6a1)
vkarve-chef added a commit that referenced this pull request Nov 4, 2022
@vkarve-chef
Update rb-fsevent SHA in sync with updated version in Gemfile (#2923)
12e7df8 
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
(cherry picked from commit 3e1b6a1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashiqueps ashiqueps ashiqueps approved these changes

@nikhil2611 nikhil2611 nikhil2611 approved these changes

Assignees
No one assigned
Labels
Expeditor: Skip All Used to skip all merge_actions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkarve-chef @ashiqueps @nikhil2611