Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: staging deploy; 9/20/22 #457

Merged
merged 11 commits into from
Sep 20, 2022
Merged

chore: staging deploy; 9/20/22 #457

merged 11 commits into from
Sep 20, 2022

Conversation

nayib-jose-gloria
Copy link
Contributor

Reviewers

Functional:

Readability:


Changes

  • add
  • remove
  • modify

atarashansky and others added 11 commits September 15, 2022 11:01
* update explorer to use two X arrays

* update for backwards compatibility

* bug fix

* fix accidental recursion

* fix shape return

* more fixes to backwards compatibility

* black

* black

* update to use attr(0) for unit tests failing due to anonymous attr name

* refactor row array name

* make use for dictionary encoded obs array

* update query_obs_array

* update query_obs_array

* fix_typo

* black

* fix faulty except block

* remaster pbmc3k.cxg obs array

* remaster

* black

* black p2

* revert

* update docs

* revert

* update docs

* revise not mandatory

* add comment

* clearer arg

* remove param from docstring

* version update

* update arg usage to colwise

* add clause

* update tests with sparse data fixture

* black

* update tests

* update tests

* combine more tests with subtests

Co-authored-by: atarashansky <atarashansky@czimacos3990.lan>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>
* wip

* wip

* wip

* revert push_tests branch change

Co-authored-by: Mike Lin <mlin@CZIMACOS3726.hawaii.rr.com>
Co-authored-by: atarashansky <atarashansky@chanzuckerberg.com>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net>
* added unified navbar

* clean up

* updates

* remove Roboto declaration

* remove Embedding and Autosave

* remove home from dataset selector and move it to the bottom - add dropdown to help

* fix lint

* fix: SVG import

* upgrade node version

* add Roboto Condensed

* fix: add back code change dropped from resolving merge conflicts

* chore: update package-lock.json

* fix: ts lint

* update test

* update test

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>
Co-authored-by: Timmy Huang <thuang@chanzuckerberg.com>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>
* add server timing to dataset query and encode

* add server timing to dataset query and encode

* remove f strings

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>
…for handling dict encoded arrays in the callback (#454)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net>
@nayib-jose-gloria nayib-jose-gloria changed the title staging deploy; 9/20/22 chore: staging deploy; 9/20/22 Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #457 (92c5237) into staging (fc35d0c) will increase coverage by 0.35%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           staging     #457      +/-   ##
===========================================
+ Coverage    74.65%   75.00%   +0.35%     
===========================================
  Files          100      100              
  Lines         7756     7818      +62     
===========================================
+ Hits          5790     5864      +74     
+ Misses        1966     1954      -12     
Flag Coverage Δ
frontend 75.00% <83.33%> (+0.35%) ⬆️
javascript 75.00% <83.33%> (+0.35%) ⬆️
smokeTest ∅ <ø> (∅)
unitTest 75.00% <83.33%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/app/api/v2.py 95.23% <ø> (ø)
server/app/api/v3.py 96.00% <0.00%> (ø)
server/dataset/cxg_dataset.py 84.81% <82.69%> (-0.22%) ⬇️
server/dataset/dataset.py 75.89% <83.87%> (+2.49%) ⬆️
server/compute/diffexp_cxg.py 84.54% <100.00%> (+3.84%) ⬆️
dataset/cxg_dataset.py 84.81% <0.00%> (-0.22%) ⬇️
dataset/dataset.py 75.89% <0.00%> (+2.49%) ⬆️
compute/diffexp_cxg.py 84.54% <0.00%> (+3.84%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nayib-jose-gloria nayib-jose-gloria merged commit f1615ec into staging Sep 20, 2022
nayib-jose-gloria added a commit that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants