Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: staging deploy; 9/20/22 #457

Merged
merged 11 commits into from
Sep 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/.nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v16
2 changes: 1 addition & 1 deletion client/__tests__/e2e/__snapshots__/e2e.test.ts.snap

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions client/__tests__/e2e/cellxgeneActions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export async function drag(testId: any, start: any, end: any, lasso = false) {
const y2 = elBox.content[0].y + end.y;
await page.mouse.move(x1, y1);
await page.mouse.down();

if (lasso) {
await page.mouse.move(x2, y1);
await page.mouse.move(x2, y2);
Expand All @@ -38,6 +39,7 @@ export async function drag(testId: any, start: any, end: any, lasso = false) {
} else {
await page.mouse.move(x2, y2);
}

await page.mouse.up();
}

Expand Down
8 changes: 4 additions & 4 deletions client/__tests__/e2e/data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const datasets = {
lasso: [
{
"coordinates-as-percent": { x1: 0.1, y1: 0.25, x2: 0.7, y2: 0.75 },
count: "1131",
count: "1094",
},
],
categorical: [
Expand Down Expand Up @@ -83,7 +83,7 @@ export const datasets = {
values: ["B cells", "Megakaryocytes"],
},
],
count: "357",
count: "332",
categorical: {
louvain: {
"B cells": "342",
Expand All @@ -98,14 +98,14 @@ export const datasets = {
},
lasso: {
"coordinates-as-percent": { x1: 0.25, y1: 0.05, x2: 0.75, y2: 0.55 },
count: "332",
count: "357",
},
},
scatter: {
genes: { x: "S100A8", y: "FCGR3A" },
},
pan: {
"coordinates-as-percent": { x1: 0.75, y1: 0.75, x2: 0.35, y2: 0.35 },
"coordinates-as-percent": { x1: 0.75, y1: 0.75, x2: 0.25, y2: 0.25 },
},
features: {
panzoom: {
Expand Down
23 changes: 13 additions & 10 deletions client/__tests__/e2e/e2e.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -350,17 +350,20 @@ describe("graph overlay", () => {
`${categoryValue}-centroid-label`
);

await drag("layout-graph", panCoords.start, panCoords.end, false);
const terminalCoordinates = await getElementCoordinates(
`${categoryValue}-centroid-label`
);
await tryUntil(async () => {
await drag("layout-graph", panCoords.start, panCoords.end, false);

expect(terminalCoordinates[0] - initialCoordinates[0]).toBeCloseTo(
panCoords.end.x - panCoords.start.x
);
expect(terminalCoordinates[1] - initialCoordinates[1]).toBeCloseTo(
panCoords.end.y - panCoords.start.y
);
const terminalCoordinates = await getElementCoordinates(
`${categoryValue}-centroid-label`
);

expect(terminalCoordinates[0] - initialCoordinates[0]).toBeCloseTo(
panCoords.end.x - panCoords.start.x
);
expect(terminalCoordinates[1] - initialCoordinates[1]).toBeCloseTo(
panCoords.end.y - panCoords.start.y
);
});
});
});

Expand Down
3 changes: 1 addition & 2 deletions client/configuration/webpack/SUPPORTED_BROWSERS_REGEX.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions client/configuration/webpack/webpack.config.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ const devConfig = {
output: {
pathinfo: true,
filename: "static/js/bundle.js",
publicPath: "/", // ensures the static asset calls use "/" as the root and not "/<base_url>/<dataset>"
// (thuang): This is needed to make sure static asset url path is '/static/assets/',
// so it ignores the base_url (/d, /e) and dataset in the url.
// e.g., http://localhost:3000/static/assets/heatmap.svg
publicPath: "/",
},
module: {
rules: [
Expand All @@ -39,7 +42,6 @@ const devConfig = {
{
test: /\.(jpg|png|gif|eot|svg|ttf|woff|woff2|otf)$/i,
loader: "file-loader",
include: [nodeModules, fonts],
options: {
name: "static/assets/[name].[ext]",
// (thuang): This is needed to make sure @font url path is '/static/assets/'
Expand Down
3 changes: 0 additions & 3 deletions client/configuration/webpack/webpack.config.prod.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,8 @@ const prodConfig = {
{
test: /\.(jpg|png|gif|eot|svg|ttf|woff|woff2|otf)$/i,
loader: "file-loader",
include: [nodeModules, fonts],
options: {
name: "static/assets/[name]-[contenthash].[ext]",
// (thuang): This is needed to make sure @font url path is '../static/assets/'
publicPath: "..",
},
},
],
Expand Down
10 changes: 9 additions & 1 deletion client/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,27 @@
label,
text,
div {
font-family: "Roboto Condensed", "Helvetica Neue", "Helvetica", "Arial", sans-serif;
font-family: "Roboto Condensed", "Helvetica Neue", "Helvetica", "Arial",
sans-serif;
font-size: 14px;
letter-spacing: -0.006em;
}
body {
margin: 0;
padding: 0;
-webkit-font-smoothing: antialiased;
}

* {
box-sizing: border-box;
}
</style>
<link rel="preconnect" href="https://fonts.googleapis.com" />
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
<link
href="https://fonts.googleapis.com/css2?family=Roboto+Condensed:ital,wght@0,400;0,700;1,400&display=swap"
rel="stylesheet"
/>
</head>
<body>
<script type="text/javascript">
Expand Down
Loading