Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CXG version 0.3.0 to list of allowed versions. #446

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

atarashansky
Copy link
Contributor

The new CXGs are not valid because the updated version is not included in the list of allowed versions. This PR is a one-liner to fix that.

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #446 (debdb01) into main (65ffb05) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   75.02%   75.02%           
=======================================
  Files         100      100           
  Lines        7800     7800           
=======================================
  Hits         5852     5852           
  Misses       1948     1948           
Flag Coverage Δ
frontend 75.02% <100.00%> (ø)
javascript 75.02% <100.00%> (ø)
unitTest 75.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/dataset/cxg_dataset.py 85.66% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atarashansky atarashansky merged commit d9b77d8 into main Sep 16, 2022
@atarashansky atarashansky deleted the atar/fix-valid-version branch September 16, 2022 16:55
nayib-jose-gloria added a commit that referenced this pull request Sep 20, 2022
* Updating explorer to appropriately handle upgraded CXGs (#431)

* update explorer to use two X arrays

* update for backwards compatibility

* bug fix

* fix accidental recursion

* fix shape return

* more fixes to backwards compatibility

* black

* black

* update to use attr(0) for unit tests failing due to anonymous attr name

* refactor row array name

* make use for dictionary encoded obs array

* update query_obs_array

* update query_obs_array

* fix_typo

* black

* fix faulty except block

* remaster pbmc3k.cxg obs array

* remaster

* black

* black p2

* revert

* update docs

* revert

* update docs

* revise not mandatory

* add comment

* clearer arg

* remove param from docstring

* version update

* update arg usage to colwise

* add clause

* update tests with sparse data fixture

* black

* update tests

* update tests

* combine more tests with subtests

Co-authored-by: atarashansky <atarashansky@czimacos3990.lan>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* Upgrade Flask and other server python dependencies (#438)

* wip

* wip

* wip

* revert push_tests branch change

Co-authored-by: Mike Lin <mlin@CZIMACOS3726.hawaii.rr.com>
Co-authored-by: atarashansky <atarashansky@chanzuckerberg.com>

* bug fix (#446)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net>

* Added the data portal navigation bar to explorer (#382)

* added unified navbar

* clean up

* updates

* remove Roboto declaration

* remove Embedding and Autosave

* remove home from dataset selector and move it to the bottom - add dropdown to help

* fix lint

* fix: SVG import

* upgrade node version

* add Roboto Condensed

* fix: add back code change dropped from resolving merge conflicts

* chore: update package-lock.json

* fix: ts lint

* update test

* update test

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>
Co-authored-by: Timmy Huang <thuang@chanzuckerberg.com>

* chore(node): Upgrade to 16 in Dockerfile (#448)

* update doc version (#447)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net>

* fix(navbar): WMG link (#449)

* fix edge case where categories dont exist for categoricals (#450)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* chore: Add server timings to gene expression API routes (#451)

* add server timing to dataset query and encode

* add server timing to dataset query and encode

* remove f strings

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net>

* fix timing (#452)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* revert mapColumns to default behavior. engineers are now responsible for handling dict encoded arrays in the callback (#454)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net>

Co-authored-by: atarashansky <atarashansky@chanzuckerberg.com>
Co-authored-by: atarashansky <atarashansky@czimacos3990.lan>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>
Co-authored-by: Mike Lin <mlin@mlin.net>
Co-authored-by: Mike Lin <mlin@CZIMACOS3726.hawaii.rr.com>
Co-authored-by: Timmy Huang <thuang@chanzuckerberg.com>
Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants