-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add server timings to gene expression API routes #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 74.96% 75.00% +0.03%
==========================================
Files 100 100
Lines 7806 7818 +12
==========================================
+ Hits 5852 5864 +12
Misses 1954 1954
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
metakuni
approved these changes
Sep 19, 2022
nayib-jose-gloria
added a commit
that referenced
this pull request
Sep 20, 2022
* Updating explorer to appropriately handle upgraded CXGs (#431) * update explorer to use two X arrays * update for backwards compatibility * bug fix * fix accidental recursion * fix shape return * more fixes to backwards compatibility * black * black * update to use attr(0) for unit tests failing due to anonymous attr name * refactor row array name * make use for dictionary encoded obs array * update query_obs_array * update query_obs_array * fix_typo * black * fix faulty except block * remaster pbmc3k.cxg obs array * remaster * black * black p2 * revert * update docs * revert * update docs * revise not mandatory * add comment * clearer arg * remove param from docstring * version update * update arg usage to colwise * add clause * update tests with sparse data fixture * black * update tests * update tests * combine more tests with subtests Co-authored-by: atarashansky <atarashansky@czimacos3990.lan> Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net> Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * Upgrade Flask and other server python dependencies (#438) * wip * wip * wip * revert push_tests branch change Co-authored-by: Mike Lin <mlin@CZIMACOS3726.hawaii.rr.com> Co-authored-by: atarashansky <atarashansky@chanzuckerberg.com> * bug fix (#446) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net> * Added the data portal navigation bar to explorer (#382) * added unified navbar * clean up * updates * remove Roboto declaration * remove Embedding and Autosave * remove home from dataset selector and move it to the bottom - add dropdown to help * fix lint * fix: SVG import * upgrade node version * add Roboto Condensed * fix: add back code change dropped from resolving merge conflicts * chore: update package-lock.json * fix: ts lint * update test * update test Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> Co-authored-by: Timmy Huang <thuang@chanzuckerberg.com> * chore(node): Upgrade to 16 in Dockerfile (#448) * update doc version (#447) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net> * fix(navbar): WMG link (#449) * fix edge case where categories dont exist for categoricals (#450) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * chore: Add server timings to gene expression API routes (#451) * add server timing to dataset query and encode * add server timing to dataset query and encode * remove f strings Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net> * fix timing (#452) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * revert mapColumns to default behavior. engineers are now responsible for handling dict encoded arrays in the callback (#454) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net> Co-authored-by: atarashansky <atarashansky@chanzuckerberg.com> Co-authored-by: atarashansky <atarashansky@czimacos3990.lan> Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.hsd1.ma.comcast.net> Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> Co-authored-by: Mike Lin <mlin@mlin.net> Co-authored-by: Mike Lin <mlin@CZIMACOS3726.hawaii.rr.com> Co-authored-by: Timmy Huang <thuang@chanzuckerberg.com> Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding server timings to these routes to be able to capture regressions in query and encode times for the gene expression
X*
arrays.