Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-14.0] Backport removal of posix-signals-on-macos #7362

Merged

Conversation

ulan
Copy link
Contributor

@ulan ulan commented Oct 25, 2023

Remove the leftover usage of posix-signals-on-macos (#7360)

This follows up #6807 and removes the last remaining reference to the removed posix-signals-on-macos feature flag.

Note that lib.rs now imports mod unix on MacOS. This change is similar to the change in traphandlers.rs in #6807. It is needed for hosts that use signals instead of Mach ports on MacOs.

…ce#7360)

This follows up bytecodealliance#6807 and removes the last remaining reference to
the removed `posix-signals-on-macos` feature flag.

Note that `lib.rs` now imports `mod unix` on MacOS. This change
is similar to the change in `traphandlers.rs` in bytecodealliance#6807. It is
needed for hosts that use signals instead of Mach ports on MacOs.
@ulan ulan requested a review from a team as a code owner October 25, 2023 16:47
@ulan ulan requested review from alexcrichton and removed request for a team October 25, 2023 16:47
@alexcrichton alexcrichton merged commit ed73433 into bytecodealliance:release-14.0.0 Oct 25, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants