Remove the leftover usage of posix-signals-on-macos
#7360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows up bytecodealliance#6807 and removes the last remaining reference to the removed `posix-signals-on-macos` feature flag. Note that `lib.rs` now imports `mod unix` on MacOS. This change is similar to the change in `traphandlers.rs` in bytecodealliance#6807. It is needed for hosts that use signals instead of Mach ports on MacOs.
|
@alexcrichton: fyi, I apologise for not spotting this earlier. We will try to follow and test the |
|
No worries! Would y'all like this backported to a Wasmtime release? |
Thanks for the offer! We are updating to version 13. If it is not a lot of work to backport to 13 and 14, that would be great. Otherwise, we can also float the patch on our end until version 15. |
|
Yeah I think that's reasonable, would you be up for sending a PR to the release-{13,14}.0.0 branches? We can take care of the actual release automation from there then. |
|
Great, I'll prepare the PRs to the release branches. |
ulan
added a commit
to ulan/wasmtime
that referenced
this pull request
Oct 25, 2023
…ce#7360) This follows up bytecodealliance#6807 and removes the last remaining reference to the removed `posix-signals-on-macos` feature flag. Note that `lib.rs` now imports `mod unix` on MacOS. This change is similar to the change in `traphandlers.rs` in bytecodealliance#6807. It is needed for hosts that use signals instead of Mach ports on MacOs.
ulan
added a commit
to ulan/wasmtime
that referenced
this pull request
Oct 25, 2023
…ce#7360) This follows up bytecodealliance#6807 and removes the last remaining reference to the removed `posix-signals-on-macos` feature flag. Note that `lib.rs` now imports `mod unix` on MacOS. This change is similar to the change in `traphandlers.rs` in bytecodealliance#6807. It is needed for hosts that use signals instead of Mach ports on MacOs.
This was referenced Oct 25, 2023
alexcrichton
pushed a commit
that referenced
this pull request
Oct 25, 2023
This follows up #6807 and removes the last remaining reference to the removed `posix-signals-on-macos` feature flag. Note that `lib.rs` now imports `mod unix` on MacOS. This change is similar to the change in `traphandlers.rs` in #6807. It is needed for hosts that use signals instead of Mach ports on MacOs.
alexcrichton
pushed a commit
that referenced
this pull request
Oct 25, 2023
* Remove the leftover usage of `posix-signals-on-macos` (#7360) This follows up #6807 and removes the last remaining reference to the removed `posix-signals-on-macos` feature flag. Note that `lib.rs` now imports `mod unix` on MacOS. This change is similar to the change in `traphandlers.rs` in #6807. It is needed for hosts that use signals instead of Mach ports on MacOs. * wasi-nn: reenable CI task (#7164) The task was disabled due to a failing checksum. Since then, the `install-openvino-action` has improved and now _almost_ has cross-platform support. This change just restores the status quo in expectation that #6895 will significantly improve the testing story. prtest:full --------- Co-authored-by: Andrew Brown <andrew.brown@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up #6807 and removes the last remaining reference to the removed
posix-signals-on-macosfeature flag.Note that
lib.rsnow importsmod unixon MacOS. This change is similar to the change intraphandlers.rsin #6807. It is needed for hosts that use signals instead of Mach ports on MacOs.