Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Mach ports vs signals via Config #6807

Merged

Conversation

alexcrichton
Copy link
Member

This commit adds a Config::macos_use_mach_ports configuration option to replace the old posix-signals-on-macos compile-time Cargo feature. This'll make Wasmtime a tad larger on macOS but likely negligibly so. Otherwise this is intended to provide a resolution to #6785 where embedders will be able to use any build of Wasmtime and configure at runtime how trap handling should happen.

Functionally this commit additionally registers a pthread_atfork handler to cause any usage of Wasmtime in the child to panic. This should help head off a known-invalid state in case anyone runs into it in the future.

This commit adds a `Config::macos_use_mach_ports` configuration option
to replace the old `posix-signals-on-macos` compile-time Cargo feature.
This'll make Wasmtime a tad larger on macOS but likely negligibly so.
Otherwise this is intended to provide a resolution to bytecodealliance#6785 where
embedders will be able to use any build of Wasmtime and configure at
runtime how trap handling should happen.

Functionally this commit additionally registers a `pthread_atfork`
handler to cause any usage of Wasmtime in the child to panic. This
should help head off a known-invalid state in case anyone runs into it
in the future.
@alexcrichton alexcrichton requested review from a team as code owners August 4, 2023 23:51
@alexcrichton alexcrichton requested review from itsrainy and removed request for a team August 4, 2023 23:51
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Aug 5, 2023
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thanks for the detailed comment on the ports config!

@alexcrichton alexcrichton added this pull request to the merge queue Aug 9, 2023
Merged via the queue into bytecodealliance:main with commit 959c648 Aug 9, 2023
19 checks passed
@alexcrichton alexcrichton deleted the runtime-macos-signals branch August 9, 2023 17:33
eduardomourar pushed a commit to eduardomourar/wasmtime that referenced this pull request Aug 18, 2023
* Configure Mach ports vs signals via `Config`

This commit adds a `Config::macos_use_mach_ports` configuration option
to replace the old `posix-signals-on-macos` compile-time Cargo feature.
This'll make Wasmtime a tad larger on macOS but likely negligibly so.
Otherwise this is intended to provide a resolution to bytecodealliance#6785 where
embedders will be able to use any build of Wasmtime and configure at
runtime how trap handling should happen.

Functionally this commit additionally registers a `pthread_atfork`
handler to cause any usage of Wasmtime in the child to panic. This
should help head off a known-invalid state in case anyone runs into it
in the future.

* Fix build on non-macOS
ulan added a commit to ulan/wasmtime that referenced this pull request Oct 25, 2023
This follows up bytecodealliance#6807 and removes the last remaining reference to
the removed `posix-signals-on-macos` feature flag.

Note that `lib.rs` now imports `mod unix` on MacOS. This change
is similar to the change in `traphandlers.rs` in bytecodealliance#6807. It is
needed for hosts that use signals instead of Mach ports on MacOs.
github-merge-queue bot pushed a commit that referenced this pull request Oct 25, 2023
This follows up #6807 and removes the last remaining reference to
the removed `posix-signals-on-macos` feature flag.

Note that `lib.rs` now imports `mod unix` on MacOS. This change
is similar to the change in `traphandlers.rs` in #6807. It is
needed for hosts that use signals instead of Mach ports on MacOs.
ulan added a commit to ulan/wasmtime that referenced this pull request Oct 25, 2023
…ce#7360)

This follows up bytecodealliance#6807 and removes the last remaining reference to
the removed `posix-signals-on-macos` feature flag.

Note that `lib.rs` now imports `mod unix` on MacOS. This change
is similar to the change in `traphandlers.rs` in bytecodealliance#6807. It is
needed for hosts that use signals instead of Mach ports on MacOs.
ulan added a commit to ulan/wasmtime that referenced this pull request Oct 25, 2023
…ce#7360)

This follows up bytecodealliance#6807 and removes the last remaining reference to
the removed `posix-signals-on-macos` feature flag.

Note that `lib.rs` now imports `mod unix` on MacOS. This change
is similar to the change in `traphandlers.rs` in bytecodealliance#6807. It is
needed for hosts that use signals instead of Mach ports on MacOs.
alexcrichton pushed a commit that referenced this pull request Oct 25, 2023
This follows up #6807 and removes the last remaining reference to
the removed `posix-signals-on-macos` feature flag.

Note that `lib.rs` now imports `mod unix` on MacOS. This change
is similar to the change in `traphandlers.rs` in #6807. It is
needed for hosts that use signals instead of Mach ports on MacOs.
alexcrichton pushed a commit that referenced this pull request Oct 25, 2023
* Remove the leftover usage of `posix-signals-on-macos` (#7360)

This follows up #6807 and removes the last remaining reference to
the removed `posix-signals-on-macos` feature flag.

Note that `lib.rs` now imports `mod unix` on MacOS. This change
is similar to the change in `traphandlers.rs` in #6807. It is
needed for hosts that use signals instead of Mach ports on MacOs.

* wasi-nn: reenable CI task (#7164)

The task was disabled due to a failing checksum. Since then, the
`install-openvino-action` has improved and now _almost_ has
cross-platform support. This change just restores the status quo in
expectation that #6895 will significantly improve the testing story.

prtest:full

---------

Co-authored-by: Andrew Brown <andrew.brown@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants