liberate wasi-common from Rights #6265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 21, 2023 16:29
the sole thing rights are used to determine is whether a path_open is opening for reading and writing.
pchickey
requested review from
jameysharp and
sunfishcode
and removed request for
a team and
jameysharp
Subscribe to Label Actioncc @kubkon
This issue or pull request has been labeled: "wasi"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
pchickey
pushed a commit
to bytecodealliance/preview2-prototyping
that referenced
this pull request
Apr 24, 2023
…r rights bytecodealliance/wasmtime#6265 note, im leaving out upstream changes to fd_readdir which are from bytecodealliance/wasmtime#6163, which requires porting the rest of that PR into this repo
sunfishcode
pushed a commit
to bytecodealliance/preview2-prototyping
that referenced
this pull request
Apr 24, 2023
* Revert "wasi-tests: add configuration to ignore rights readback (#81)" This reverts commit 087179a. * wasi-tests: pull in all changes from upstream which remove support for rights bytecodealliance/wasmtime#6265 note, im leaving out upstream changes to fd_readdir which are from bytecodealliance/wasmtime#6163, which requires porting the rest of that PR into this repo * remove rights readback variable from test runner * rustfmt * delete path_open_read_without_rights test which was deleted upstream
alexcrichton
approved these changes
Apr 27, 2023
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Apr 28, 2023
* tests: remove all use of rights for anything besides path_open read | write * wasi-common and friends: delete all Caps from FileEntry and DirEntry the sole thing rights are used to determine is whether a path_open is opening for reading and writing.
pchickey
added a commit
to pchickey/wasmtime
that referenced
this pull request
May 16, 2023
* Revert "wasi-tests: add configuration to ignore rights readback (bytecodealliance#81)" This reverts commit d006b1b. * wasi-tests: pull in all changes from upstream which remove support for rights bytecodealliance#6265 note, im leaving out upstream changes to fd_readdir which are from bytecodealliance#6163, which requires porting the rest of that PR into this repo * remove rights readback variable from test runner * rustfmt * delete path_open_read_without_rights test which was deleted upstream
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more restricting Rights. It was a failed experiment, it has effectively no adoption, and its presence in the test suite is impeding the transition to Preview 2.
All use of Rights throughout wasi-common is now removed, except for the
fs_rights_baseargument topath_openusingRIGHTS_FD_READto indicateO_RDONLYandRIGHTS_FD_WRITEto indicateO_WRONLY.All use of Rights is removed from the test suite, except for read/write. Portions of tests that check whether rights are available are deleted, only the read and write rights are ever passed, and the entire
path_open_read_without_rightstest is deleted, since its whole purpose was to measure that dropping rights worked.