Fix free_iovs guest pointer mapping in polyfill #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, good find! Running in the simple shell.html driver, I hadn't yet had a chance to test stdin. I'll add a README about this, but just so you know, the polyfill is now being maintained on the polyfill branch, so I'll cherry-pick this PR over there. |
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
* Track memory usage * Track lowest_used in copy, etc. * Extra comment for used_size
pchickey
added a commit
to pchickey/wasmtime
that referenced
this pull request
May 16, 2023
* Revert "wasi-tests: add configuration to ignore rights readback (bytecodealliance#81)" This reverts commit d006b1b. * wasi-tests: pull in all changes from upstream which remove support for rights bytecodealliance#6265 note, im leaving out upstream changes to fd_readdir which are from bytecodealliance#6163, which requires porting the rest of that PR into this repo * remove rights readback variable from test runner * rustfmt * delete path_open_read_without_rights test which was deleted upstream
mooori
pushed a commit
to mooori/wasmtime
that referenced
this pull request
Dec 20, 2023
Remove vmctx in ZkasmEnvironment
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
Apr 4, 2024
This patch improves the local names used within the `call_builtin` ever-so-slightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this change in order for data from stdin to be correctly received in the guest wasi module buffer when running in the polyfill.