This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
wasi-tests: add configuration to ignore rights readback #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is broken at the moment and is getting in the way of testing more interesting bits of functionality. we'll re-enable it once other stuff is working.
|
Makes sense! Right now it makes sense to focus on getting the main functionality working. |
pchickey
pushed a commit
that referenced
this pull request
Apr 24, 2023
This reverts commit 087179a.
sunfishcode
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Revert "wasi-tests: add configuration to ignore rights readback (#81)" This reverts commit 087179a. * wasi-tests: pull in all changes from upstream which remove support for rights bytecodealliance/wasmtime#6265 note, im leaving out upstream changes to fd_readdir which are from bytecodealliance/wasmtime#6163, which requires porting the rest of that PR into this repo * remove rights readback variable from test runner * rustfmt * delete path_open_read_without_rights test which was deleted upstream
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readback of the rights fields is broken at the moment and is getting in the way of testing more interesting bits of functionality. We'll re-enable it once other stuff is working.