[pull] 4.0-dev from joomla:4.0-dev #128

pull · 2021-08-09T08:30:45Z

See Commits and Changes for more details.

Can you help keep this open source service alive? 💖 Please sponsor : )

…when both belong to same vendor. (#34954) * [4.0] (#34910) Updating or uninstalling one library no longer removes another when both belong to same vendor. ### Summary of Changes Check if there are any other children before removing vendor folder. ### Testing instructions As described in #34910 * Added blank line for PHP code style error. * Removed the empty arrays for the last 2 parameters of Folder::folders() so the defaults are used As suggestion made in pull comment. * Removed unnecessary optional parameters from Folder::folders()

* [4.0] remove file check * cleanup debug

When navigating with the keyboard a focus outline is applied to the tabs However as can be seen in this enlargement the outline is cut on the right. This PR adjusts the z-index to prevent that

* Remove wrong information from code comment * More precise comment about discovered extensions

…ate (#35070)

@conconnl

…d by @conconnl

hound · 2021-08-09T08:31:16Z

administrator/components/com_media/resources/scripts/app/Api.es6.js

+      .map((directory) => this._normalizeItem(directory));
+    const files = data.filter((item) => (item.type === 'file'))
+      // eslint-disable-next-line no-underscore-dangle
+      .map((file) => this._normalizeItem(file));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-08-09T08:31:16Z

administrator/components/com_media/resources/scripts/app/Api.es6.js

+    const directories = data.filter((item) => (item.type === 'dir'))
+      // eslint-disable-next-line no-underscore-dangle
+      .map((directory) => this._normalizeItem(directory));
+    const files = data.filter((item) => (item.type === 'file'))


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-08-09T08:31:16Z

administrator/components/com_media/resources/scripts/app/Api.es6.js

+  _normalizeArray(data) {
+    const directories = data.filter((item) => (item.type === 'dir'))
+      // eslint-disable-next-line no-underscore-dangle
+      .map((directory) => this._normalizeItem(directory));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-08-09T08:31:16Z

administrator/components/com_media/resources/scripts/app/Api.es6.js

+     */
+  // eslint-disable-next-line no-underscore-dangle
+  _normalizeArray(data) {
+    const directories = data.filter((item) => (item.type === 'dir'))


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-08-09T08:31:17Z

administrator/components/com_media/resources/scripts/app/Event.es6.js

+     */
+  fire(event, data = null) {
+    if (this.events[event]) {
+      this.events[event].forEach((fn) => fn(data));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

…5073)

Co-authored-by: Thomas Hunziker <werbemails@bakual.ch>

* Allow the translation bot to recompile the htmls * Update cleanup-media.es6.js * Update cleanup-media.es6.js * Update build/build-modules-js/init/cleanup-media.es6.js Co-authored-by: Brian Teeman <brian@teeman.net> * Update cleanup-media.es6.js Co-authored-by: Brian Teeman <brian@teeman.net>

* [4.0] One more * Update cleanup-media.es6.js

…5510) * Fix pre-update check wrong update required information * Fix wrong code comment * Simplify code * Revert unrelated change for collection URLs * Optimize code * Use array_values for the intersect * PHPCS

hound · 2021-09-11T21:59:29Z

administrator/components/com_media/resources/scripts/plugins/translate.es6.js

+      return val;
+    });
+  },
+  install: (Vue) => Vue.mixin({


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T21:59:29Z

administrator/components/com_media/resources/scripts/plugins/translate.es6.js

+
+const Translate = {
+  // Translate from Joomla text
+  translate: (key) => Joomla.Text._(key, key),


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T21:59:29Z

administrator/components/com_media/resources/scripts/store/actions.es6.js

+ */
+export const toggleBrowserItemSelect = (context, payload) => {
+  const item = payload;
+  const isSelected = context.state.selectedItems.some((selected) => selected.path === item.path);


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T21:59:29Z

administrator/components/com_media/resources/scripts/store/getters.es6.js

+ * @returns {Array|files|{}|FileList|*}
+ */
+export const getSelectedDirectoryFiles = (state) => state.files
+  .filter((file) => (file.directory === state.selectedDirectory));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T21:59:30Z

administrator/components/com_media/resources/scripts/store/getters.es6.js

+ *
+ * @returns {Array|files|{}|FileList|*}
+ */
+export const getSelectedDirectoryFiles = (state) => state.files


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T21:59:31Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+     */
+  [types.UNSELECT_BROWSER_ITEM]: (state, payload) => {
+    const item = payload;
+    state.selectedItems.splice(state.selectedItems.findIndex(


Unexpected newline after '(' function-paren-newline

hound · 2021-09-11T21:59:31Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+    if (item.type === 'dir') {
+      state.directories.splice(state.directories.findIndex(
+        (directory) => directory.path === item.path,
+      ), 1);


Unexpected newline before ')' function-paren-newline

hound · 2021-09-11T21:59:31Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+    // Delete dir
+    if (item.type === 'dir') {
+      state.directories.splice(state.directories.findIndex(
+        (directory) => directory.path === item.path,


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T21:59:31Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+
+    // Delete dir
+    if (item.type === 'dir') {
+      state.directories.splice(state.directories.findIndex(


Unexpected newline after '(' function-paren-newline

hound · 2021-09-11T21:59:32Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+    if (item.type === 'file') {
+      state.files.splice(state.files.findIndex(
+        (file) => file.path === item.path,
+      ), 1);


Unexpected newline before ')' function-paren-newline

hound · 2021-09-11T22:00:28Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+    // Delete file
+    if (item.type === 'file') {
+      state.files.splice(state.files.findIndex(
+        (file) => file.path === item.path,


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:00:29Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+
+    // Delete file
+    if (item.type === 'file') {
+      state.files.splice(state.files.findIndex(


Unexpected newline after '(' function-paren-newline

hound · 2021-09-11T22:00:29Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+      const index = state.files.findIndex((file) => (file.path === oldPath));
+      state.files.splice(index, 1, item);
+    } else {
+      const index = state.directories.findIndex((directory) => (directory.path === oldPath));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:00:29Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+    const { item } = payload;
+    const { oldPath } = payload;
+    if (item.type === 'file') {
+      const index = state.files.findIndex((file) => (file.path === oldPath));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:00:29Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+      // Update the relation to the parent directory
+      state.directories.splice(parentDirectoryIndex,
+        1,
+        { ...parentDirectory, directories: [...parentDirectory.directories, directory.path] });


Expected a newline before ')' function-paren-newline

hound · 2021-09-11T22:00:31Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+     */
+  [types.UPLOAD_SUCCESS]: (state, payload) => {
+    const file = payload;
+    const isNew = (!state.files.some((existing) => (existing.path === file.path)));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:00:31Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+        state.directories
+          .splice(parentDirectoryIndex,
+            1,
+            { ...parentDirectory, files: [...parentDirectory.files, file.path] });


Expected a newline before ')' function-paren-newline

hound · 2021-09-11T22:00:31Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+      // Update the relation to the parent directory
+      if (parentDirectoryIndex !== -1) {
+        state.directories
+          .splice(parentDirectoryIndex,


Expected a newline after '(' function-paren-newline

hound · 2021-09-11T22:00:31Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+      const parentDirectory = state.directories
+        .find((directory) => (directory.path === file.directory));
+      const parentDirectoryIndex = state.directories.indexOf(parentDirectory);
+      let index = state.files.findIndex((existing) => (existing.path === file.path));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:00:32Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+    // eslint-disable-next-line no-shadow
+    function addFile(state, file) {
+      const parentDirectory = state.directories
+        .find((directory) => (directory.path === file.directory));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:22:36Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+        state.directories
+          .splice(parentDirectoryIndex,
+            1,
+            { ...parentDirectory, directories: [...parentDirectory.directories, directory.path] });


Expected a newline before ')' function-paren-newline

hound · 2021-09-11T22:22:37Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+      // Update the relation to the parent directory
+      if (parentDirectoryIndex !== -1) {
+        state.directories
+          .splice(parentDirectoryIndex,


Expected a newline after '(' function-paren-newline

hound · 2021-09-11T22:22:37Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+      const parentDirectory = state.directories
+        .find((existing) => (existing.path === directory.directory));
+      const parentDirectoryIndex = state.directories.indexOf(parentDirectory);
+      let index = state.directories.findIndex((existing) => (existing.path === directory.path));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:22:37Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+    // eslint-disable-next-line no-shadow
+    function addDirectory(state, directory) {
+      const parentDirectory = state.directories
+        .find((existing) => (existing.path === directory.directory));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:22:37Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+        // Add the sub directories and files
+        directory.directories = state.directories
+          .filter((existing) => existing.directory === directory.path)
+          .map((existing) => existing.path);


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:22:37Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+
+        // Add the sub directories and files
+        directory.directories = state.directories
+          .filter((existing) => existing.directory === directory.path)


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:22:37Z

administrator/components/com_media/resources/scripts/store/mutations.es6.js

+         * @param path
+         */
+    function createDirectoryStructureFromPath(path) {
+      const exists = state.directories.some((existing) => (existing.path === path));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:22:38Z

administrator/components/com_media/resources/scripts/store/state.es6.js

+  displayName: disk.displayName,
+  drives: getDrives(disk.adapterNames, disk.name),
+}));
+const defaultDisk = loadedDisks.find((disk) => disk.drives.length > 0


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:22:38Z

administrator/components/com_media/resources/scripts/store/state.es6.js

+};
+
+// Load disks from options
+const loadedDisks = options.providers.map((disk) => ({


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

hound · 2021-09-11T22:22:38Z

administrator/components/com_media/resources/scripts/store/state.es6.js

+ */
+const getDrives = (adapterNames, provider) => {
+  const drives = [];
+  adapterNames.map((name) => drives.push({ root: `${provider}-${name}:/`, displayName: name }));


Unexpected parentheses around single function argument having a body with no curly braces arrow-parens

This updates the skipto js to the newly released 4.1.2 ### Version 4.1.2 Added aria-busy="true" attribute to menu element when SkipTo is initialized and being updated with new menu items to support validators looking for required menu items for the menu role. Added the optional aria-controls attribute to button element to reference the id of the menu element as defined in the W3C ARIA Authoring practices for menu button pattern. ### Version 4.1.1 Removed aria-describedby from button, since screen readers read the accesskey information.

Fixes bug #35454 (Debug plugin: Debug bar doesn't display logs and deprecated tabs by default, while setting's default is ON)

If you do not have the track session metadata option enabled in global configuration then the admin module for Logged Users displays an appropriate message. This PR simply styles the module output correctly to be consistent

* [J4] Adds support for custom class on subforms via xml * [J4] Adds support for custom class on subforms via xml

BrainforgeUK and others added 21 commits August 2, 2021 10:35

[4.0] remove file check (#35038)

4ee89be

* [4.0] remove file check * cleanup debug

Align the paths for child templates (#35024)

bdc8320

[4.0] Improve Language::transliterate method (#35029)

572d0dd

added php8 to list of filtered extensions (#35001)

2ae50ce

Fix language strings plural suffixes unit test (#35026)

ca04b45

Fix (#35011)

31ce0de

[4.0] tab focus (#35022)

59649f7

When navigating with the keyboard a focus outline is applied to the tabs However as can be seen in this enlargement the outline is cut on the right. This PR adjusts the z-index to prevent that

Fix incomplete npm update of custom elements (#35058)

a43f682

[staging] Fix jalali calendar javascript (#28700)

f9b55e9

Remove wrong information from code comment (#35037)

6d150e7

* Remove wrong information from code comment * More precise comment about discovered extensions

Don't use hard-coded extension_id in update SQL scripts (#35034)

5378a26

Remove wrong css (#35061)

7823dc0

Exclude "/media/system/images" from files and folders deletion on upd…

03a0ea4

…ate (#35070)

[4.0] short and sweet fix (#35039)

9a87e5b

[4.0] Check target file extension of com_media rename action (#34999)

4ee06a1

added php8 to list of filtered extensions (#35000)

9523fb6

Merge branch '3.10-dev' of github.com:joomla/joomla-cms into staging

756031e

Update crowdin.yml with the new EOS Plugin language files as requeste…

d6c5ab8

…d by @conconnl

Update the EOS plugin with the final EOS date

c764d4d

Correct params in onContentPrepare call (#35045)

69243dd

pull bot added the ⤵️ pull label Aug 9, 2021

hound bot reviewed Aug 9, 2021

View reviewed changes

pull bot added the merge-conflict Resolve conflicts manually label Aug 9, 2021

richard67 and others added 6 commits August 9, 2021 11:39

Use attachments column for insertObject (#35074)

cab9a16

Update branches and fix some references still pointing to staging (#3…

e983254

…5073)

Make fontawesome+icomoon mapping available as Joomla asset (#32541)

894ce3e

[4.0] Collapse / accordion function for categories list (#33052)

c2740e9

[4.0] Eliminating cpanel jumping (#35069)

a73153e

sanitize parent_id as an int (#34989)

cfeb626

ReLater and others added 9 commits September 9, 2021 18:13

[4.0] Make note field hideable (#35017)

696d3b6

[4] Remove default secret (#35139)

82e8252

Lookup correct form path (#35523)

36d0214

Co-authored-by: Thomas Hunziker <werbemails@bakual.ch>

fix undefined class (#35459)

0d156a2

[4.0] One more (#35533)

b1a3f7b

* [4.0] One more * Update cleanup-media.es6.js

[3.10] Fix misleading "Update Required" in the pre-update checker (#3…

f2581cc

…5510) * Fix pre-update check wrong update required information * Fix wrong code comment * Simplify code * Revert unrelated change for collection URLs * Optimize code * Use array_values for the intersect * PHPCS

Merge branch '3.10-dev' into 4.0-dev

6615552

[4.0] Make transitions translateable (#35457)

3ab6503

hound bot reviewed Sep 11, 2021

View reviewed changes

Translation Update (#35379)

5921e43

hound bot reviewed Sep 11, 2021

View reviewed changes

dgrammatiko and others added 16 commits September 12, 2021 10:05

provide the real path as data-attr (#35049)

9025817

Update deleted files and folders to changes from PR #34890 (#35478)

6cc8c09

Fix syntax

fb5bdcd

Tag 4.0.3 RC

35dc6ce

Reset to dev

2d2b51f

Fix Cassiopeia Offline (#35553)

e97dcbe

Fix wrong since tag coming from upmerge with deploy version (#35551)

3e7c933

Tag 4.0.3 stable

27ffee6

Reset to dev

a181a68

Adapt modal articles to articles (#35564)

6900bb9

ZIP extraction helper for Joomla Update (#35388)

1a569d2

Fixes Debug bar not displaying logs by default #35454 (#35455)

a6fbc4c

Fixes bug #35454 (Debug plugin: Debug bar doesn't display logs and deprecated tabs by default, while setting's default is ON)

[4.0] Logged in users module (#35589)

7e49a2f

If you do not have the track session metadata option enabled in global configuration then the admin module for Logged Users displays an appropriate message. This PR simply styles the module output correctly to be consistent

[J4] Adds support for custom class on subforms via xml (#35577)

86d021c

* [J4] Adds support for custom class on subforms via xml * [J4] Adds support for custom class on subforms via xml

rm cassiopeia/images/system (#35549)

32a13f0

brianteeman closed this Sep 19, 2021

[pull] 4.0-dev from joomla:4.0-dev #128

[pull] 4.0-dev from joomla:4.0-dev #128

Conversation

pull bot commented Aug 9, 2021 • edited Loading

hound bot Aug 9, 2021

Choose a reason for hiding this comment

hound bot Aug 9, 2021

Choose a reason for hiding this comment

hound bot Aug 9, 2021

Choose a reason for hiding this comment

hound bot Aug 9, 2021

Choose a reason for hiding this comment

hound bot Aug 9, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

hound bot Sep 11, 2021

Choose a reason for hiding this comment

pull bot commented Aug 9, 2021 •

edited

Loading