[4.0.x] Update skipto #35590
Merged
[4.0.x] Update skipto #35590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the skipto js to the newly released 4.1.2 ### Version 4.1.2 Added aria-busy="true" attribute to menu element when SkipTo is initialized and being updated with new menu items to support validators looking for required menu items for the menu role. Added the optional aria-controls attribute to button element to reference the id of the menu element as defined in the W3C ARIA Authoring practices for menu button pattern. ### Version 4.1.1 Removed aria-describedby from button, since screen readers read the accesskey information.
joomla-cms-bot
added
NPM Resource Changed
|
Thanks! |
|
thanks |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Oct 3, 2021
This updates the skipto js to the newly released 4.1.2 ### Version 4.1.2 Added aria-busy="true" attribute to menu element when SkipTo is initialized and being updated with new menu items to support validators looking for required menu items for the menu role. Added the optional aria-controls attribute to button element to reference the id of the menu element as defined in the W3C ARIA Authoring practices for menu button pattern. ### Version 4.1.1 Removed aria-describedby from button, since screen readers read the accesskey information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the skipto js to the newly released 4.1.2 - nothing spectacular changed apart from fixing an issue with WAVE tester making a false error report
Version 4.1.2
Added aria-busy="true" attribute to menu element when SkipTo is initialized and being updated with new menu items to support validators looking for required menu items for the menu role.
Added the optional aria-controls attribute to button element to reference the id of the menu element as defined in the W3C ARIA Authoring practices for menu button pattern.
Version 4.1.1
Removed aria-describedby from button, since screen readers read the accesskey information.