Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Adapt modal articles to articles #35564

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Sep 14, 2021

Pull Request for Issue #35548.

The issue comes from line break in the title link.
It could be resolved also by writiing the link in one line or by using HtmlHelper.
But it is better when the articles are displayed always in the same format.

Summary of Changes

Make a new line for Alias after title, so the article list is the same in list view and modal.

Testing Instructions

see issue

Actual result BEFORE applying this Pull Request

see issue

Expected result AFTER applying this Pull Request

grafik

Documentation Changes Required

@ChristineWk
Copy link

I have tested this item ✅ successfully on f0fbced


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35564.

@alikon
Copy link
Contributor

alikon commented Sep 15, 2021

I have tested this item ✅ successfully on f0fbced


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35564.

@alikon
Copy link
Contributor

alikon commented Sep 15, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35564.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 15, 2021
@Quy Quy added this to the Joomla 4.0.4 milestone Sep 16, 2021
@Quy Quy merged commit 6900bb9 into joomla:4.0-dev Sep 16, 2021
@Quy
Copy link
Contributor

Quy commented Sep 16, 2021

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 16, 2021
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Oct 3, 2021
@chmst chmst deleted the articles-modal-same-as-articles branch August 4, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants