Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3567 credit offers edit #3591

Merged
merged 2 commits into from
Nov 28, 2022
Merged

#3567 credit offers edit #3591

merged 2 commits into from
Nov 28, 2022

Conversation

ihorml
Copy link
Contributor

@ihorml ihorml commented Nov 22, 2022

Issue #3567

Description

  • I have renamed the title of Amount for edit dialog. Now it is a "Currently Available Balance" (to avoid misunderstanding)
  • Fixed the balance check to avoid the fake error which blocked the edit
  • Fixed the delta amount which sends to the blockchain
  • Added the "Total to Repay" for Repay window (I had a misunderstanding and insufficient balance error, so I decided to display for a user the sum that gonna be withdrawn from his account (credit fee + repay amount)

Screenshot 2022-11-22 at 10 46 33

Screenshot 2022-11-22 at 10 48 08

Closes #3567

This was referenced Nov 22, 2022
Merged
Merged
@sschiessl-bcp sschiessl-bcp merged commit e9706fd into bitshares:develop Nov 28, 2022
@sschiessl-bcp sschiessl-bcp added this to In progress in 5.0.230113 Release via automation Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.230113 Release
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credit offer - cannot edit existing offer
2 participants
@ihorml @sschiessl-bcp