Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3533 Feature credit offer overflow validation #3594

Merged
merged 1 commit into from
Dec 17, 2022
Merged

#3533 Feature credit offer overflow validation #3594

merged 1 commit into from
Dec 17, 2022

Conversation

ihorml
Copy link
Contributor

@ihorml ihorml commented Nov 23, 2022

Issue #3533

Description

  • This PR is based on this one - #3567 credit offers edit #3591
  • Catch & detect overflow issues and display a user-friendly error (for create & edit)
  • Add min_loan > total_balance error (for create & edit)

Screenshot 2022-11-23 at 04 29 34

Screenshot 2022-11-23 at 04 29 12

Closes #3533

@sschiessl-bcp
Copy link
Contributor

can you rebase please?

@ihorml ihorml force-pushed the feature-credit-offer-overflow-validation branch from dea30f6 to 5ee62ca Compare November 30, 2022 09:44
@ihorml
Copy link
Contributor Author

ihorml commented Nov 30, 2022

Done

@sschiessl-bcp sschiessl-bcp added this to In progress in 5.0.230113 Release via automation Dec 17, 2022
@sschiessl-bcp sschiessl-bcp merged commit 097f4bb into bitshares:develop Dec 17, 2022
5.0.230113 Release automation moved this from In progress to Done Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.230113 Release
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credit offer field max limits (field validation)
2 participants
@ihorml @sschiessl-bcp