-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credit offer - cannot edit existing offer #3567
Comments
@abitmore hey there. I've fixed the issue on a front-end side but looks like the same bug applies to blockchain logic. I have already existed offer and I changed a whitelisted account only: When I tries to update the offer I see the following error: Please redirect me in the right direction if I get the logic of the credit offer update in the wrong way. But from my user perspective, if I updates the whitelisted account and didn't touch the amount of offer - it should be updated fine. |
@abitmore okay, what I see from the logic is the field "amount" is used like an "amount to change" instead of "total amount" (what User expects to see) In this case, the UI has a bad UX and I'll change the title to a proper one to avoid misunderstanding. |
I think a better UX is that showing the new amount (and probably the change too) and submitting the change to the blockchain, just like the UX about borrowing bitUSD. Thanks. |
@abitmore hm, good point. I'll show an amount field and send to the blockchain a delta of current/new to update it in a proper way. Thanks! |
…licated collateral
Describe the bug
I have offered all of one asset I own in a credit offer.
When I try to edit the credit offer, I'm unable to click submit because I have 0 of the asset I wish to lend (as it's all in this credit offer I'm trying to edit).
I am thus unable to edit a credit offer in the web wallet.
To Reproduce
Create a credit offer, offer all of an asset in your balance (1 of 1 for example) for loan.
Go to your created credit offer in your portfolio, click the edit button.
Try to make any changes, you cannot.
The available balance is highlighted red, indicating it's failing the form validation, despite not wanting to change the offered asset quantity but rather the expiration date.
Expected behavior
I can edit a credit offer I have created.
Screenshots
![image](https://user-images.githubusercontent.com/15861527/193297548-eb0e8d86-5751-495e-bc34-414afee8198a.png)
Desktop (please complete the following information):
web wallet, firefox
Additional context
To edit the credit offer I have to delete it and create it from scratch.
The text was updated successfully, but these errors were encountered: