docs: Documentation and clean up of bevy_math. #3503

ghost · 2021-12-31T03:54:07Z

This PR is part of the issue #3492.
Closes #335.
Closes #3484.

Objective

Add and update the bevy_math documentation to achieve a 100% documentation coverage.
Add the #![warn(missing_docs)] lint to keep the documentation coverage for the future.
Remove the face_toward.rs file containing the FaceToward trait, because it is unused.
Move the geometry.rs file to bevy_ui and rename the Rect type to UiRect to remove having two types with the same name (see bevy_sprite::Rect).
Remove bevy_ui::Margins.
Add a new(left: T, right: T, top: T, bottom: T) function for bevy_ui::UiRect.
Change Size<T> to Size<Val> removing the generic, because Val should be extendable enough.
Change UiRect<T> to UiRect<Val> removing the generic, because Val should be extendable enough.
Document the behaviour of different position settings to clarify how the current UI implementation will react.
Check if bevy_math works with the doc_markdown lint.
Check if bevy_ui works with the doc_markdown lint.

Solution

alice-i-cecile

This is excellent, thank you! I left a few comments with my thoughts, let me know what you think.

crates/bevy_math/src/face_toward.rs

crates/bevy_math/src/geometry.rs

crates/bevy_math/src/face_toward.rs

crates/bevy_math/src/lib.rs

mockersf

Is the FaceToward trait really needed? It seems it's only duplicate functionality from https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh. It's never used in Bevy code. There's also bitshifter/glam-rs#214, @alice-i-cecile do you have more information?

Reading the doc on Rect, I find it very confusing. Looking through its usage in code:

first thing I noticed, we actually have two different structs named Rect, the other one is defined in bevy_sprite and has a much more logical definition

bevy/crates/bevy_sprite/src/rect.rs

Lines 8 to 13 in 1d0d8a3

    
           pub struct Rect { 
        
               /// The beginning point of the rect 
        
               pub min: Vec2, 
        
               /// The ending point of the rect 
        
               pub max: Vec2, 
        
           }

the Rect struct in bevy_math is, as you noted, only used in bevy_ui, and it doesn't actually define a rectangle, only what to do to each side of one (with of a border, width of a padding, ...)

I think the Rect from bevy_math should be moved to bevy_ui (and renamed), and it could probably lose the type parameter as I think it's only used with Val.

There is a pretty similar situation with the Size struct in bevy_math. It's only used as a generic Vec2, and that's only needed in bevy_ui as it's needed to have a Vec2 over Val, which is not possible with the Vec2 from glam. Most other places in code that need a size use directly a Vec2.

I think the Size struct should move to bevy_ui and not be generic anymore. Other place that needs a size should use a Vec2 instead as it's way more powerful.

So... my recommendations to document bevy_math is to remove all its modules, then it won't need that much doc 😄

ghost · 2021-12-31T15:11:57Z

I agree with what you said.

I was also wondering what the point of the FaceToward Trait is, because it is never used and I was just able to remove the whole module without any errors. Maybe there are some people that use this functionality in their games, but I guess we have to go the same route as you did recently and just remove it and see if someone complains.

I'll start working on moving the geometry.rs to bevy_ui and renaming the Rect. Do you or anyone here have some recommendations on a new name that is more fitting and doesn't conflict with the Rect from bevy_sprite?

I will most likely remove the example which included use bevy_math::prelude::*; (see discussion above), since I don't want to add use bevy::math::prelude::*; with an ignore flag.

alice-i-cecile · 2021-12-31T19:33:21Z

Is the FaceToward trait really needed? It seems it's only duplicate functionality from https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh. It's never used in Bevy code. There's also bitshifter/glam-rs#214, @alice-i-cecile do you have more information?

I agree! IMO we should make sure we've exposed that, and then use that functionality instead, deleting the FaceForward trait.

I'll start working on moving the geometry.rs to bevy_ui and renaming the Rect.

I agree with this choice too. Perhaps Padding @KDecay?

I will most likely remove the example which included use bevy_math::prelude::; (see discussion above), since I don't want to add use bevy::math::prelude::; with an ignore flag.

Agreed.

This all looks excellent: although the scope is larger, it's nice to fix up some of these code quality issues while we're here. Can you update the PR title @KDecay once you're done so it's easier to track in the git log? Something like "Documented and cleaned up bevy_math" would be fine.

MinerSebas · 2022-01-01T00:28:18Z

The bevy_sprite::Rect != bevy_math::Rect fact was prevoisly brought up in #335.

ghost · 2022-01-01T03:16:35Z

I agree with this choice too. Perhaps Padding?

That could work yeah. We came up with a simple UiRect in the discord, but Padding could also work. I'll probably just stick to UiRect for now. We can discuss the final name after I did all the points mentioned and the name seems inaccurate.

The bevy_sprite::Rect != bevy_math::Rect fact was prevoisly brought up in #335.

Thanks for mentioning. The Rect of bevy_math will be moved to bevy_ui and also receive a rename to remove the duplicate type name. I'll consider and check the points mentioned in the issue and implement them as needed, so that we can close that issue.

This all looks excellent: although the scope is larger, it's nice to fix up some of these code quality issues while we're here. Can you update the PR title once you're done so it's easier to track in the git log? Something like "Documented and cleaned up bevy_math" would be fine.

Yes of course. I'll update the title and also the objective so that it's clear what happened here.

ghost · 2022-01-01T06:48:17Z

What I did

I removed every module inside of bevy_math so it is only a lib file which is using the glam crate.
I also removed the examples inside of the bevy_math lib file.
The code coverage of bevy_math is now at 100%.

The FaceToward trait got completely removed and the Size and Rect got moved to bevy_ui.
The Rect also received a rename and is now called UiRect.

@alice-i-cecile I decided to go with UiRect instead of Padding because the UiRect is used for positions, margins, paddings and borders, so calling it just Padding would be confusing.

Removing `bevy_ui::Margins`

I checked #335 and the issue is still present. Inside of the bevy_ui crate there is a margins.rs which contains the Margins type. This type seems obsolete and should be replaced by the UiRect in my opinion, because the UiRect is also used for margins and could cause confusion. The only thing that UiRect isn't capable of is the new(left: T, right: T, top: T, bottom: T) function, which could easily be implemented, if needed.

Since we are removing a whole type we could also just ignore the new() function and keep it the way it currently is with defining it using UiRect { .. }. The Margins type is completely unused inside of bevy code so it is only used by users of bevy. If users use this type it would make it easier to migrate to UiRect if we added a new() function to UiRect. In my opinion we should do exactly this and add a new() function and remove the whole margins.rs file.

Let me know if we should do it and also if it should be inside of this PR or if we should create a new one!

alice-i-cecile · 2022-01-01T06:53:06Z

I really like your proposed change; let's do this here so it doesn't get decoupled.

Thanks for the excellent work!

ghost · 2022-01-01T18:59:50Z

What I did

I removed the margins.rs from bevy_ui and added the new(left: T, right: T, top: T, bottom: T)function to UiRect.

Migration Guide

old: bevy_math::Rect new: bevy_ui::UiRect
- They are identical, but bevy_ui::UiRect has an additional new(..) function.
- To migrate it is only required to change the path to the type and the type.
old: bevy_math::Size new: bevy_ui::Size
- They are identical.
- To migrate it is only required to change the path to the type.
old: bevy_math::Mat4::face_toward(...) new: bevy_math::Mat4::look_at_rh(...)
- They should be identical (see https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh).
- To migrate it is only required to change the function name.
old: bevy_ui::Margins new: bevy_ui::UiRect
- They are not identical, but bevy_ui::UiRect has every functionality of bevy_ui::Margins.
- To migrate it is only required to change the type name.
The Trait FaceToward got removed.
- This trait was only used for the Mat4 type, but if any user used this in their own projects they have to create this trait themselves.
- To migrate we suggest using the bevy_math::Mat4::look_at_rh function or to create a trait that provides this functionality (see https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh).

james7132 · 2022-01-01T19:25:49Z

No migration possible.

Probably should suggest to use https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh instead, as stated above.

ghost · 2022-01-01T19:31:30Z

Probably should suggest to use https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh instead, as stated above.

True, but this would only allow the users to use the look_at_rh(...) function of the bevy_math::Mat4 type. So if someone has their own type which needs the face_toward(...) or look_at_rh(...) function they would still have to implement that themselves.

I edited my last comment so that we have at least some sort of migration guide to provide for users. Thanks for pointing that out!

crates/bevy_math/src/lib.rs

ghost · 2022-03-21T00:05:04Z

Going to close this down and split it into multiple smaller PR's to make it easier to review and merge.

# Objective - Closes #335. - Part of the splitting process of #3503. ## Solution - Remove the `margins.rs` file containing the `Margins` type. ## Reasons - It is unused inside of `bevy`. - The `Rect`/`UiRect` is identical to the `Margins` type and is also used for margins inside of `bevy` (rename of `Rect` happens in #4276) - Discussion in #3503. ## Changelog ### Removed - The `Margins` type got removed. ## Migration Guide - The `Margins` type got removed. To migrate you just have to change every occurrence of `Margins` to `UiRect`.

# Objective - Part of the splitting process of #3503. ## Solution - Remove the `face_toward.rs` file containing the `FaceToward` trait. ## Reasons - It is unused inside of `bevy`. - The method `Mat4::face_toward` of the trait is identical to `Mat4::look_at_rh` (see https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh). - Discussion in #3503. ## Changelog ### Removed - The `FaceToward` trait got removed. ## Migration Guide - The `FaceToward` trait got removed. To migrate you just have to change every occurrence of `Mat4::face_toward` to `Mat4::look_at_rh`.

# Objective - Related #4276. - Part of the splitting process of #3503. ## Solution - Move `Size` to `bevy_ui`. ## Reasons - `Size` is only needed in `bevy_ui` (because it needs to use `Val` instead of `f32`), but it's also used as a worse `Vec2` replacement in other areas. - `Vec2` is more powerful than `Size` so it should be used whenever possible. - Discussion in #3503. ## Changelog ### Changed - The `Size` type got moved from `bevy_math` to `bevy_ui`. ## Migration Guide - The `Size` type got moved from `bevy::math` to `bevy::ui`. To migrate you just have to import `bevy::ui::Size` instead of `bevy::math::Math` or use the `bevy::prelude` instead. Co-authored-by: KDecay <KDecayMusic@protonmail.com>

# Objective - Closes #335. - Related #4285. - Part of the splitting process of #3503. ## Solution - Move `Rect` to `bevy_ui` and rename it to `UiRect`. ## Reasons - `Rect` is only used in `bevy_ui` and therefore calling it `UiRect` makes the intent clearer. - We have two types that are called `Rect` currently and it's missleading (see `bevy_sprite::Rect` and #335). - Discussion in #3503. ## Changelog ### Changed - The `Rect` type got moved from `bevy_math` to `bevy_ui` and renamed to `UiRect`. ## Migration Guide - The `Rect` type got renamed to `UiRect`. To migrate you just have to change every occurrence of `Rect` to `UiRect`. Co-authored-by: KDecay <KDecayMusic@protonmail.com>

# Objective - Related bevyengine#4276. - Part of the splitting process of bevyengine#3503. ## Solution - Move `Size` to `bevy_ui`. ## Reasons - `Size` is only needed in `bevy_ui` (because it needs to use `Val` instead of `f32`), but it's also used as a worse `Vec2` replacement in other areas. - `Vec2` is more powerful than `Size` so it should be used whenever possible. - Discussion in bevyengine#3503. ## Changelog ### Changed - The `Size` type got moved from `bevy_math` to `bevy_ui`. ## Migration Guide - The `Size` type got moved from `bevy::math` to `bevy::ui`. To migrate you just have to import `bevy::ui::Size` instead of `bevy::math::Math` or use the `bevy::prelude` instead. Co-authored-by: KDecay <KDecayMusic@protonmail.com>

# Objective - Closes bevyengine#335. - Related bevyengine#4285. - Part of the splitting process of bevyengine#3503. ## Solution - Move `Rect` to `bevy_ui` and rename it to `UiRect`. ## Reasons - `Rect` is only used in `bevy_ui` and therefore calling it `UiRect` makes the intent clearer. - We have two types that are called `Rect` currently and it's missleading (see `bevy_sprite::Rect` and bevyengine#335). - Discussion in bevyengine#3503. ## Changelog ### Changed - The `Rect` type got moved from `bevy_math` to `bevy_ui` and renamed to `UiRect`. ## Migration Guide - The `Rect` type got renamed to `UiRect`. To migrate you just have to change every occurrence of `Rect` to `UiRect`. Co-authored-by: KDecay <KDecayMusic@protonmail.com>

# Objective - Closes bevyengine#335. - Part of the splitting process of bevyengine#3503. ## Solution - Remove the `margins.rs` file containing the `Margins` type. ## Reasons - It is unused inside of `bevy`. - The `Rect`/`UiRect` is identical to the `Margins` type and is also used for margins inside of `bevy` (rename of `Rect` happens in bevyengine#4276) - Discussion in bevyengine#3503. ## Changelog ### Removed - The `Margins` type got removed. ## Migration Guide - The `Margins` type got removed. To migrate you just have to change every occurrence of `Margins` to `UiRect`.

# Objective - Part of the splitting process of bevyengine#3503. ## Solution - Remove the `face_toward.rs` file containing the `FaceToward` trait. ## Reasons - It is unused inside of `bevy`. - The method `Mat4::face_toward` of the trait is identical to `Mat4::look_at_rh` (see https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh). - Discussion in bevyengine#3503. ## Changelog ### Removed - The `FaceToward` trait got removed. ## Migration Guide - The `FaceToward` trait got removed. To migrate you just have to change every occurrence of `Mat4::face_toward` to `Mat4::look_at_rh`.

# Objective - Migrate changes from #3503. ## Solution - Document `Size` and `UiRect`. - I also removed the type alias from the `size_ops` test since it's unnecessary. ## Follow Up After this change is merged I'd follow up with removing the generics from `Size` and `UiRect` since `Val` should be extensible enough. This was also discussed and decided on in #3503. let me know if this is not needed or wanted anymore!

# Objective - Migrate changes from #3503. ## Solution - Change `Size<T>` and `UiRect<T>` to `Size` and `UiRect` using `Val`. - Implement `Sub`, `SubAssign`, `Mul`, `MulAssign`, `Div` and `DivAssign` for `Val`. - Update tests for `Size`. --- ## Changelog ### Changed - The generic `T` of `Size` and `UiRect` got removed and instead they both now always use `Val`. ## Migration Guide - The generic `T` of `Size` and `UiRect` got removed and instead they both now always use `Val`. If you used a `Size<f32>` consider replacing it with a `Vec2` which is way more powerful. Co-authored-by: KDecay <KDecayMusic@protonmail.com>

# Objective - Migrate changes from bevyengine#3503. ## Solution - Document `Size` and `UiRect`. - I also removed the type alias from the `size_ops` test since it's unnecessary. ## Follow Up After this change is merged I'd follow up with removing the generics from `Size` and `UiRect` since `Val` should be extensible enough. This was also discussed and decided on in bevyengine#3503. let me know if this is not needed or wanted anymore!

# Objective - Migrate changes from bevyengine#3503. ## Solution - Change `Size<T>` and `UiRect<T>` to `Size` and `UiRect` using `Val`. - Implement `Sub`, `SubAssign`, `Mul`, `MulAssign`, `Div` and `DivAssign` for `Val`. - Update tests for `Size`. --- ## Changelog ### Changed - The generic `T` of `Size` and `UiRect` got removed and instead they both now always use `Val`. ## Migration Guide - The generic `T` of `Size` and `UiRect` got removed and instead they both now always use `Val`. If you used a `Size<f32>` consider replacing it with a `Vec2` which is way more powerful. Co-authored-by: KDecay <KDecayMusic@protonmail.com>

# Objective - Migrate changes from bevyengine#3503. ## Solution - Document `Size` and `UiRect`. - I also removed the type alias from the `size_ops` test since it's unnecessary. ## Follow Up After this change is merged I'd follow up with removing the generics from `Size` and `UiRect` since `Val` should be extensible enough. This was also discussed and decided on in bevyengine#3503. let me know if this is not needed or wanted anymore!

# Objective - Migrate changes from bevyengine#3503. ## Solution - Change `Size<T>` and `UiRect<T>` to `Size` and `UiRect` using `Val`. - Implement `Sub`, `SubAssign`, `Mul`, `MulAssign`, `Div` and `DivAssign` for `Val`. - Update tests for `Size`. --- ## Changelog ### Changed - The generic `T` of `Size` and `UiRect` got removed and instead they both now always use `Val`. ## Migration Guide - The generic `T` of `Size` and `UiRect` got removed and instead they both now always use `Val`. If you used a `Size<f32>` consider replacing it with a `Vec2` which is way more powerful. Co-authored-by: KDecay <KDecayMusic@protonmail.com>

# Objective - Closes bevyengine#335. - Part of the splitting process of bevyengine#3503. ## Solution - Remove the `margins.rs` file containing the `Margins` type. ## Reasons - It is unused inside of `bevy`. - The `Rect`/`UiRect` is identical to the `Margins` type and is also used for margins inside of `bevy` (rename of `Rect` happens in bevyengine#4276) - Discussion in bevyengine#3503. ## Changelog ### Removed - The `Margins` type got removed. ## Migration Guide - The `Margins` type got removed. To migrate you just have to change every occurrence of `Margins` to `UiRect`.

# Objective - Part of the splitting process of bevyengine#3503. ## Solution - Remove the `face_toward.rs` file containing the `FaceToward` trait. ## Reasons - It is unused inside of `bevy`. - The method `Mat4::face_toward` of the trait is identical to `Mat4::look_at_rh` (see https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh). - Discussion in bevyengine#3503. ## Changelog ### Removed - The `FaceToward` trait got removed. ## Migration Guide - The `FaceToward` trait got removed. To migrate you just have to change every occurrence of `Mat4::face_toward` to `Mat4::look_at_rh`.

# Objective - Related bevyengine#4276. - Part of the splitting process of bevyengine#3503. ## Solution - Move `Size` to `bevy_ui`. ## Reasons - `Size` is only needed in `bevy_ui` (because it needs to use `Val` instead of `f32`), but it's also used as a worse `Vec2` replacement in other areas. - `Vec2` is more powerful than `Size` so it should be used whenever possible. - Discussion in bevyengine#3503. ## Changelog ### Changed - The `Size` type got moved from `bevy_math` to `bevy_ui`. ## Migration Guide - The `Size` type got moved from `bevy::math` to `bevy::ui`. To migrate you just have to import `bevy::ui::Size` instead of `bevy::math::Math` or use the `bevy::prelude` instead. Co-authored-by: KDecay <KDecayMusic@protonmail.com>

# Objective - Closes bevyengine#335. - Related bevyengine#4285. - Part of the splitting process of bevyengine#3503. ## Solution - Move `Rect` to `bevy_ui` and rename it to `UiRect`. ## Reasons - `Rect` is only used in `bevy_ui` and therefore calling it `UiRect` makes the intent clearer. - We have two types that are called `Rect` currently and it's missleading (see `bevy_sprite::Rect` and bevyengine#335). - Discussion in bevyengine#3503. ## Changelog ### Changed - The `Rect` type got moved from `bevy_math` to `bevy_ui` and renamed to `UiRect`. ## Migration Guide - The `Rect` type got renamed to `UiRect`. To migrate you just have to change every occurrence of `Rect` to `UiRect`. Co-authored-by: KDecay <KDecayMusic@protonmail.com>

github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 31, 2021

alice-i-cecile added A-Math Fundamental domain-agnostic mathematical operations C-Docs An addition or correction to our documentation and removed S-Needs-Triage This issue needs to be labelled labels Dec 31, 2021

alice-i-cecile requested changes Dec 31, 2021

View reviewed changes

crates/bevy_math/src/face_toward.rs Outdated Show resolved Hide resolved

crates/bevy_math/src/geometry.rs Outdated Show resolved Hide resolved

crates/bevy_math/src/geometry.rs Outdated Show resolved Hide resolved

crates/bevy_math/src/geometry.rs Outdated Show resolved Hide resolved

alice-i-cecile approved these changes Dec 31, 2021

View reviewed changes

alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 31, 2021

mockersf reviewed Dec 31, 2021

View reviewed changes

crates/bevy_math/src/face_toward.rs Outdated Show resolved Hide resolved

mockersf reviewed Dec 31, 2021

View reviewed changes

crates/bevy_math/src/lib.rs Outdated Show resolved Hide resolved

mockersf reviewed Dec 31, 2021

View reviewed changes

crates/bevy_math/src/lib.rs Outdated Show resolved Hide resolved

mockersf requested changes Dec 31, 2021

View reviewed changes

mockersf removed the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 31, 2021

alice-i-cecile mentioned this pull request Dec 31, 2021

Upstream face_toward from Bevy bitshifter/glam-rs#214

Closed

ghost changed the title ~~Added and updated bevy_math documentation.~~ Documentation and clean up of bevy_math. Jan 1, 2022

alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change S-Needs-Migration-Guide labels Jan 1, 2022

alice-i-cecile mentioned this pull request Jan 1, 2022

Tracking issue: deny missing docs, one crate at a time #3492

Open

45 tasks

ghost requested review from mockersf and alice-i-cecile January 1, 2022 22:32

alice-i-cecile reviewed Jan 2, 2022

View reviewed changes

crates/bevy_math/src/lib.rs Outdated Show resolved Hide resolved

KDecay and others added 2 commits March 19, 2022 05:26

Merge branch 'main' into update_bevy_math_doc

ed4fff5

Fix low_power example

c617884

ghost closed this Mar 21, 2022

This was referenced Mar 21, 2022

[Merged by Bors] - Move Rect to bevy_ui and rename it to UiRect #4276

Closed

[Merged by Bors] - Remove face_toward.rs #4277

Closed

[Merged by Bors] - Remove margins.rs #4284

Closed

[Merged by Bors] - Move Size to bevy_ui #4285

Closed

ghost mentioned this pull request Jul 19, 2022

[Merged by Bors] - Document Size and UiRect #5381

Closed

ghost mentioned this pull request Jul 20, 2022

[Merged by Bors] - Remove Size and UiRect generics #5404

Closed

ghost deleted the update_bevy_math_doc branch August 7, 2022 08:27

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Documentation and clean up of bevy_math. #3503

docs: Documentation and clean up of bevy_math. #3503

ghost commented Dec 31, 2021 •

edited by ghost

Loading

alice-i-cecile left a comment

mockersf left a comment •

edited

Loading

ghost commented Dec 31, 2021

alice-i-cecile commented Dec 31, 2021

MinerSebas commented Jan 1, 2022

ghost commented Jan 1, 2022

ghost commented Jan 1, 2022

alice-i-cecile commented Jan 1, 2022

ghost commented Jan 1, 2022 •

edited by ghost

Loading

james7132 commented Jan 1, 2022

ghost commented Jan 1, 2022 •

edited by ghost

Loading

ghost commented Mar 21, 2022

	pub struct Rect {
	/// The beginning point of the rect
	pub min: Vec2,
	/// The ending point of the rect
	pub max: Vec2,
	}

docs: Documentation and clean up of bevy_math. #3503

docs: Documentation and clean up of bevy_math. #3503

Conversation

ghost commented Dec 31, 2021 • edited by ghost Loading

Objective

Solution

alice-i-cecile left a comment

Choose a reason for hiding this comment

mockersf left a comment • edited Loading

Choose a reason for hiding this comment

ghost commented Dec 31, 2021

alice-i-cecile commented Dec 31, 2021

MinerSebas commented Jan 1, 2022

ghost commented Jan 1, 2022

ghost commented Jan 1, 2022

What I did

Removing bevy_ui::Margins

alice-i-cecile commented Jan 1, 2022

ghost commented Jan 1, 2022 • edited by ghost Loading

What I did

Migration Guide

james7132 commented Jan 1, 2022

ghost commented Jan 1, 2022 • edited by ghost Loading

ghost commented Mar 21, 2022

ghost commented Dec 31, 2021 •

edited by ghost

Loading

mockersf left a comment •

edited

Loading

Removing `bevy_ui::Margins`

ghost commented Jan 1, 2022 •

edited by ghost

Loading

ghost commented Jan 1, 2022 •

edited by ghost

Loading