[Merged by Bors] - Remove margins.rs
#4284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
A-UI
mockersf
approved these changes
Mar 21, 2022
james7132
approved these changes
Mar 21, 2022
james7132
added
the
S-Ready-For-Final-Review
ghost
mentioned this pull request
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
# Objective - Closes #335. - Part of the splitting process of #3503. ## Solution - Remove the `margins.rs` file containing the `Margins` type. ## Reasons - It is unused inside of `bevy`. - The `Rect`/`UiRect` is identical to the `Margins` type and is also used for margins inside of `bevy` (rename of `Rect` happens in #4276) - Discussion in #3503. ## Changelog ### Removed - The `Margins` type got removed. ## Migration Guide - The `Margins` type got removed. To migrate you just have to change every occurrence of `Margins` to `UiRect`.
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - Closes bevyengine#335. - Part of the splitting process of bevyengine#3503. ## Solution - Remove the `margins.rs` file containing the `Margins` type. ## Reasons - It is unused inside of `bevy`. - The `Rect`/`UiRect` is identical to the `Margins` type and is also used for margins inside of `bevy` (rename of `Rect` happens in bevyengine#4276) - Discussion in bevyengine#3503. ## Changelog ### Removed - The `Margins` type got removed. ## Migration Guide - The `Margins` type got removed. To migrate you just have to change every occurrence of `Margins` to `UiRect`.
ghost
deleted the
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Closes bevyengine#335. - Part of the splitting process of bevyengine#3503. ## Solution - Remove the `margins.rs` file containing the `Margins` type. ## Reasons - It is unused inside of `bevy`. - The `Rect`/`UiRect` is identical to the `Margins` type and is also used for margins inside of `bevy` (rename of `Rect` happens in bevyengine#4276) - Discussion in bevyengine#3503. ## Changelog ### Removed - The `Margins` type got removed. ## Migration Guide - The `Margins` type got removed. To migrate you just have to change every occurrence of `Margins` to `UiRect`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
margins.rsfile containing theMarginstype.Reasons
bevy.Rect/UiRectis identical to theMarginstype and is also used for margins inside ofbevy(rename ofRecthappens in [Merged by Bors] - MoveRecttobevy_uiand rename it toUiRect#4276)Changelog
Removed
Marginstype got removed.Migration Guide
Marginstype got removed. To migrate you just have to change every occurrence ofMarginstoUiRect.