Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream face_toward from Bevy #214

Closed
alice-i-cecile opened this issue Jul 7, 2021 · 3 comments
Closed

Upstream face_toward from Bevy #214

alice-i-cecile opened this issue Jul 7, 2021 · 3 comments

Comments

@alice-i-cecile
Copy link

As implemented here, this is a very convenient utility function that other users could benefit from.

Doing so would allow Bevy to deprecate our own implementation and avoid the extension trait.

@bitshifter
Copy link
Owner

As glam intends to be co-ordinate system agnostic it would need to be renamed face_toward_rh and a corresponding face_toward_lh should also be added.

Bevy switched from Mat4::look_at_rh to Mat4::face_toward in this commit bevyengine/bevy@3ee8aa8 but it's unclear to me why this change was made? How does this function differ from Mat4::look_at_rh? It looks like perhaps Mat4::face_toward is the same as Mat4::look_at_rh().inverse()? What is the benefit of one over the other for the purpose of documentation and explaining these methods to users?

@alice-i-cecile
Copy link
Author

Hmm. That's a very good question. I'll ask around.

@alice-i-cecile
Copy link
Author

Closing, per the discussion in bevyengine/bevy#3503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants