Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick 0.4.2 #367

Merged
merged 2 commits into from
Apr 7, 2017
Merged

Cherrypick 0.4.2 #367

merged 2 commits into from
Apr 7, 2017

Commits on Apr 7, 2017

  1. go_repository: add importpath and vcs flags (bazelbuild#313) (bazelbu… 

    …ild#319)

* go_repository: add importpath and vcs flags (bazelbuild#313)

This change allows fetch_repo to fetch repositories without attempting
to determine the repo root if the user supplies the information
themselves. This allows users to be able to fetch repositories that the
vcs package would otherwise not be able to recognize.

This change also changes the behavior of the --remote flag to match the
git_repository rule.

* Respond to jayconrod@ comments in bazelbuild#319.

* Add BUILD rule for fetch_repo_test.go
* Stub out vcs.RepoRootForImportPath
* Make remote and vcs flags not being set in fetch_repo a hard error.
* Verify VCS is not nil before returning it in a RepoRoot.

* Fix go_repository rule for bazelbuild#319.

Since the vcs field in go_repository was always set to "git", fetch_repo was
always failing if the user passed in only the importpath.
    @wlynch
    wlynch authored and Jay Conrod committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    150e36c View commit details
    Browse the repository at this point in the history

  2. Fetch buildifier from new location (bazelbuild#362) 

    The github.com/bazelbuild/buildifier repository was renamed to
buildtools. With this change, we download from the new location but
keep the old import path.

Fixes bazelbuild#361
    @jayconrod
    jayconrod authored and Jay Conrod committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    9f72561 View commit details
    Browse the repository at this point in the history