Cherrypick 0.4.2 #367
Merged
Cherrypick 0.4.2 #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild#319) * go_repository: add importpath and vcs flags (bazelbuild#313) This change allows fetch_repo to fetch repositories without attempting to determine the repo root if the user supplies the information themselves. This allows users to be able to fetch repositories that the vcs package would otherwise not be able to recognize. This change also changes the behavior of the --remote flag to match the git_repository rule. * Respond to jayconrod@ comments in bazelbuild#319. * Add BUILD rule for fetch_repo_test.go * Stub out vcs.RepoRootForImportPath * Make remote and vcs flags not being set in fetch_repo a hard error. * Verify VCS is not nil before returning it in a RepoRoot. * Fix go_repository rule for bazelbuild#319. Since the vcs field in go_repository was always set to "git", fetch_repo was always failing if the user passed in only the importpath.
The github.com/bazelbuild/buildifier repository was renamed to buildtools. With this change, we download from the new location but keep the old import path. Fixes bazelbuild#361
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypicked the following changes:
Note that this PR is onto a new branch, release/0.4.2, which currently points to 0.4.1.