Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch buildifier from new location #362

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Fetch buildifier from new location #362

merged 1 commit into from
Apr 6, 2017

Conversation

jayconrod
Copy link
Contributor

The github.com/bazelbuild/buildifier repository was renamed to
buildtools. With this change, we download from the new location but
keep the old import path.

Fixes #361

Fetch buildifier from new location
c90f519 
The github.com/bazelbuild/buildifier repository was renamed to
buildtools. With this change, we download from the new location but
keep the old import path.

Fixes bazelbuild#361
@pmbethe09
Copy link
Member

LGTM

@jayconrod jayconrod mentioned this pull request Apr 6, 2017
Closed
@jayconrod jayconrod merged commit 2d9f328 into bazelbuild:master Apr 6, 2017
@jayconrod jayconrod deleted the fix-rename-buildifier branch April 6, 2017 22:28
@jayconrod jayconrod mentioned this pull request Apr 7, 2017
Closed
jayconrod added a commit to jayconrod/rules_go that referenced this pull request Apr 7, 2017
@jayconrod
Fetch buildifier from new location (bazelbuild#362)
e48c440 
The github.com/bazelbuild/buildifier repository was renamed to
buildtools. With this change, we download from the new location but
keep the old import path.

Fixes bazelbuild#361
@jayconrod jayconrod mentioned this pull request Apr 7, 2017
Merged
jayconrod added a commit to jayconrod/rules_go that referenced this pull request Apr 7, 2017
@jayconrod
Fetch buildifier from new location (bazelbuild#362)
9f72561 
The github.com/bazelbuild/buildifier repository was renamed to
buildtools. With this change, we download from the new location but
keep the old import path.

Fixes bazelbuild#361
@jayconrod jayconrod mentioned this pull request Apr 7, 2017
Merged
jayconrod added a commit that referenced this pull request Apr 7, 2017
@jayconrod
Cherrypicks for 0.3.4 release (#366)
0843ec2 
Cherrypicked the following changes:

* #319 go_repository: add importpath and vcs flags. This allows us to have separate import paths and remote URLs for repositories.
* #362 Fetch buildifier from new location. This allows the buildifier zip to be extracted with the new name.
jayconrod added a commit that referenced this pull request Apr 7, 2017
@jayconrod
Cherrypick 0.4.2 (#367)
87cdda3 
Cherrypicked the following changes:

* #319 go_repository: add importpath and vcs flags. This allows us to have separate import paths and remote URLs for repositories.
* #362 Fetch buildifier from new location. This allows the buildifier zip to be extracted with the new name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayconrod @pmbethe09 @googlebot