Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make index ingestion and metrics resubscribe pausing occur on connection as well #1932

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

hensmi-amazon
Copy link
Contributor

Issue #: #1448

Description of changes: See title/issue. This is an extension of #1841

Testing: Smoke tested using simulcast enabled chrome browsers. Am occasionally able to see the pause/resume on connection to show it is working.

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

  1. Join a meeting with simulcast and enable video.
  2. Join with another client and confirm video from other participants show promptly. Note that the key here is connected additional clients after video has been enabled, not joining all clients and then enabling video.

Checklist:

  1. Have you successfully run npm run build:release locally?
    y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
    n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
    n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hensmi-amazon hensmi-amazon merged commit 3130181 into main Jan 13, 2022
@hensmi-amazon hensmi-amazon deleted the harden-pausing branch January 13, 2022 20:24
hensmi-amazon added a commit that referenced this pull request Jan 13, 2022
ltrung pushed a commit that referenced this pull request Jan 13, 2022
bjason pushed a commit that referenced this pull request Jan 26, 2022
bjason pushed a commit that referenced this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants