Avoid race condition on asynchronous update tasks #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2021
ltrung
reviewed
Dec 1, 2021
| // need this protection because they are synchronous. | ||
| this.monitorTask.pauseResubscribeCheck(); | ||
| this.receiveIndexTask.pauseIngestion(); | ||
|
|
There was a problem hiding this comment.
race condition can still happen in other task like ReceiveVideoInputTask right?
There was a problem hiding this comment.
With integrateUplinkPolicyDecision ? I'm not too concerned about that impact since we are mostly relying on avg bitrate anyways.
There was a problem hiding this comment.
No, it can cause video to fail when calling choose video input multiple when the video is on (https://github.com/aws/amazon-chime-sdk-js/blob/master/src/task/ReceiveVideoInputTask.ts#L32). See this issue #1609 . It is exactly related to this issue you are fixing but it is another race condition in update.
ltrung
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: #1448 & #1805
Description of changes: #1448 explains issue (see my comment at bottom). This change simply defers ingestion of index/resubscribe check until after the update completes.
Testing: With the pagination demo I can repro this occaisonally if I join a meeting with 3 videos, and 2 per page, local backend. The resubscribe spam in beginning of call seem to lead to one video being missing. I don't see the issue after change. Its also trivial to inspect logs to verify this works as expected.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Not really, without looking at logs and trying to spam resubscribes.
Checklist:
Have you successfully run
npm run build:releaselocally?y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.