Make index ingestion and metrics resubscribe pausing occur on connection as well #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensmi-amazon
commented
Jan 14, 2022
| @@ -113,6 +113,9 @@ export default class JoinAndReceiveIndexTask extends BaseTask { | |||
| ); | |||
| }); | |||
| this.context.logger.info(`received first index ${JSON.stringify(indexFrame)}`); | |||
| // We currently don't bother ingesting this into the same places as `ReceiveVideoStreamIndexTask` as we synchronously attempt a first subscribe | |||
| // after this task completes and the state isn't quite in the right place to make it work without some refactoring. However that | |||
| // means that we will always have an initial subscribe without any received videos. | |||
There was a problem hiding this comment.
Sometimes you gotta pick your battles 😒
ltrung
previously approved these changes
Jan 19, 2022
ltrung
approved these changes
Jan 19, 2022
4 tasks
bjason
pushed a commit
that referenced
this pull request
Jan 26, 2022
…ion as well (#1937) Co-authored-by: Trung Le <58827450+ltrung@users.noreply.github.com>
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: #1448 (rerolling #1932)
Description of changes: See #1932. Fixed an ordering issues, and added some comments as well. Found related simulcast bug #1934 while testing.
Testing:
See #1932
Checklist:
Have you successfully run
npm run build:releaselocally?y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.