Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shape_estimation)!: fix namespace and directory structure #7844

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jul 4, 2024

Description

This PR puts headers in the autoware namespace.

Additional works

  1. Align directory structure to follow the coding guidelines.

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

refactor: relocate headers

refactor: add namespace

refactor: update shape_estimation  namespace on the user side
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
refactor: update namespace of the node

refactor: update namespace and directory structure for detection_by_tracker node
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…racker node

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin marked this pull request as ready for review July 5, 2024 04:33
@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 9.67742% with 56 lines in your changes missing coverage. Please review.

Project coverage is 28.64%. Comparing base (99c7c57) to head (23d7434).
Report is 32 commits behind head on main.

Files Patch % Lines
...tection_by_tracker/src/tracker/tracker_handler.cpp 0.00% 31 Missing ⚠️
...erception/shape_estimation/lib/shape_estimator.cpp 20.00% 12 Missing ⚠️
...erception/detection_by_tracker/src/utils/utils.hpp 0.00% 5 Missing ⚠️
...ction_by_tracker/src/detection_by_tracker_node.cpp 0.00% 3 Missing ⚠️
...tection_by_tracker/src/tracker/tracker_handler.hpp 0.00% 2 Missing ⚠️
...toware/shape_estimation/corrector/no_corrector.hpp 0.00% 1 Missing ⚠️
...ude/autoware/shape_estimation/filter/no_filter.hpp 0.00% 1 Missing ⚠️
...ion/shape_estimation/src/shape_estimation_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7844      +/-   ##
==========================================
- Coverage   28.65%   28.64%   -0.02%     
==========================================
  Files        1587     1608      +21     
  Lines      116361   116474     +113     
  Branches    49700    49718      +18     
==========================================
+ Hits        33345    33359      +14     
- Misses      74014    74110      +96     
- Partials     9002     9005       +3     
Flag Coverage Δ *Carryforward flag
differential 2.99% <9.67%> (?)
total 28.66% <ø> (+<0.01%) ⬆️ Carriedforward from 471c870

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito self-requested a review July 5, 2024 07:30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that shape_estimator.hpp needs to be made public for other packages, but many of the other .hpp files don't seem to need to be public. As a first step, it might be a good idea to merge everything first and then move the .hpp files that don't need to be public afterwards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that other than shape_estimator.hpp is closed within the package.
Directory structure may need to be aligned and fixed later.

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a trivial comment

Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the refactor/namespace-shape_estimation branch from 6fefe5d to 23d7434 Compare July 5, 2024 09:18
@technolojin technolojin enabled auto-merge (squash) July 5, 2024 09:18
@technolojin technolojin merged commit 26e87ea into autowarefoundation:main Jul 5, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants