Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(geography_utils): prefix package and namespace with autoware #7790

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jul 2, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 2, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 23.92%. Comparing base (a742e82) to head (b45cae9).
Report is 7 commits behind head on main.

Files Patch % Lines
system/default_ad_api/src/vehicle.cpp 0.00% 6 Missing ⚠️
...ware_geo_pose_projector/src/geo_pose_projector.cpp 0.00% 2 Missing ⚠️
sensing/gnss_poser/src/gnss_poser_core.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7790      +/-   ##
==========================================
+ Coverage   23.90%   23.92%   +0.01%     
==========================================
  Files        1380     1387       +7     
  Lines      101770   101868      +98     
  Branches    38731    38746      +15     
==========================================
+ Hits        24332    24369      +37     
- Misses      74992    75004      +12     
- Partials     2446     2495      +49     
Flag Coverage Δ *Carryforward flag
differential 10.51% <16.66%> (?)
total 23.90% <ø> (-0.01%) ⬇️ Carriedforward from 07c1302

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. I have one question.

According to the documentation, the recommended directory structure is autoware_{name}/include/autoware/{name}, but in this pull request, it seems to be autoware_geography_utils/include/autoware_geography_utils. Is this intentional?

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (default_ad_api package)

@esteve
Copy link
Contributor Author

esteve commented Jul 3, 2024

@SakodaShintaro thanks for pointing that out, working on it.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) and removed component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Aug 13, 2024
@esteve
Copy link
Contributor Author

esteve commented Aug 14, 2024

@mitsudome-r @youtalk could you have a look at this PR when you have a moment? It's been in the queue for over month and a half. Thanks.

1 similar comment
@esteve
Copy link
Contributor Author

esteve commented Aug 14, 2024

@mitsudome-r @youtalk could you have a look at this PR when you have a moment? It's been in the queue for over month and a half. Thanks.

@youtalk
Copy link
Member

youtalk commented Aug 14, 2024

We need approval from @kminoda, @kosuke55 and @takayuki5168 but they might be in summer vacation.

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
Copy link
Contributor Author

esteve commented Aug 14, 2024

@youtalk @kosuke55 thanks. It seems this needs approval frorm @kminoda as well.

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve esteve merged commit 59a04e5 into autowarefoundation:main Aug 15, 2024
28 of 30 checks passed
@esteve esteve deleted the prefix-geography_utils branch August 15, 2024 02:59
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
…autowarefoundation#7790)

* refactor(geography_utils): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* move headers to include/autoware/

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: xtk8532704 <1041084556@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants