Add filename to `noqa` warnings #5856

sobolevn · 2023-07-18T06:47:29Z

Summary

Before:

» ruff litestar tests --fix
warning: Invalid `# noqa` directive on line 19: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on line 65: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on line 74: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on line 22: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on line 66: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on line 75: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).

After:

» cargo run --bin ruff ../litestar/litestar ../litestar/tests
    Finished dev [unoptimized + debuginfo] target(s) in 0.15s
     Running `target/debug/ruff ../litestar/litestar ../litestar/tests`
warning: Detected debug build without --no-cache.
warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_bigint.py:19: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_bigint.py:65: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_bigint.py:74: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_uuid.py:22: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_uuid.py:66: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_uuid.py:75: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).

Test Plan

I didn't find any existing tests with this warning.

Closes #5855
Closes #5729

github-actions · 2023-07-18T07:14:48Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00     12.3±0.47ms     3.3 MB/sec    1.02     12.5±0.49ms     3.2 MB/sec
formatter/numpy/ctypeslib.py               1.02      2.5±0.14ms     6.8 MB/sec    1.00      2.4±0.12ms     6.9 MB/sec
formatter/numpy/globals.py                 1.01   283.7±13.05µs    10.4 MB/sec    1.00   281.1±20.07µs    10.5 MB/sec
formatter/pydantic/types.py                1.03      5.4±0.21ms     4.7 MB/sec    1.00      5.3±0.27ms     4.8 MB/sec
linter/all-rules/large/dataset.py          1.00     18.0±0.65ms     2.3 MB/sec    1.00     17.9±0.72ms     2.3 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.4±0.16ms     3.8 MB/sec    1.00      4.4±0.18ms     3.8 MB/sec
linter/all-rules/numpy/globals.py          1.00   585.9±21.99µs     5.0 MB/sec    1.02   594.8±40.35µs     5.0 MB/sec
linter/all-rules/pydantic/types.py         1.01      8.1±0.27ms     3.1 MB/sec    1.00      8.1±0.35ms     3.1 MB/sec
linter/default-rules/large/dataset.py      1.02      9.0±0.34ms     4.5 MB/sec    1.00      8.8±0.28ms     4.6 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.06  1947.1±76.71µs     8.6 MB/sec    1.00  1835.6±83.09µs     9.1 MB/sec
linter/default-rules/numpy/globals.py      1.00   216.1±10.28µs    13.7 MB/sec    1.02   220.1±12.37µs    13.4 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.9±0.15ms     6.6 MB/sec    1.03      4.0±0.14ms     6.4 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00     11.1±0.08ms     3.7 MB/sec    1.01     11.2±0.07ms     3.6 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.1±0.02ms     7.8 MB/sec    1.00      2.1±0.02ms     7.8 MB/sec
formatter/numpy/globals.py                 1.00    231.8±4.16µs    12.7 MB/sec    1.00    231.0±5.28µs    12.8 MB/sec
formatter/pydantic/types.py                1.00      4.7±0.06ms     5.4 MB/sec    1.00      4.7±0.04ms     5.4 MB/sec
linter/all-rules/large/dataset.py          1.01     15.5±0.09ms     2.6 MB/sec    1.00     15.4±0.09ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.1±0.02ms     4.1 MB/sec    1.00      4.1±0.04ms     4.1 MB/sec
linter/all-rules/numpy/globals.py          1.00    424.4±7.26µs     7.0 MB/sec    1.00    423.2±7.52µs     7.0 MB/sec
linter/all-rules/pydantic/types.py         1.01      7.0±0.06ms     3.6 MB/sec    1.00      7.0±0.05ms     3.7 MB/sec
linter/default-rules/large/dataset.py      1.01      8.2±0.04ms     5.0 MB/sec    1.00      8.1±0.03ms     5.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01  1640.8±13.53µs    10.1 MB/sec    1.00  1620.1±11.89µs    10.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    172.3±2.24µs    17.1 MB/sec    1.00    172.3±1.87µs    17.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.6±0.03ms     7.1 MB/sec    1.00      3.6±0.03ms     7.1 MB/sec

charliermarsh · 2023-07-18T13:57:03Z

Thank you!

sobolevn · 2023-07-18T16:27:13Z

@charliermarsh I think that you've missed this {path} formatting: https://github.com/astral-sh/ruff/pull/5856/files#diff-6bf3042a2fd2080c73f4441e878fa4658bbd973395c78f30a0db0d62c92fd98dR239

I will send a PR to also make it relative.

By the way, since the last time I've contributed - you made a huge progress. Congrats! Keep up the good work 🤗

Refs astral-sh#5856

charliermarsh · 2023-07-18T16:44:24Z

Oops, serves me right for making quick drive-by changes...

By the way, since the last time I've contributed - you made a huge progress. Congrats! Keep up the good work 🤗

Thank you so much, I really appreciate it! It's fun to see you back :)

Refs #5856

## Summary Before: ``` » ruff litestar tests --fix warning: Invalid `# noqa` directive on line 19: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on line 65: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on line 74: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on line 22: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on line 66: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on line 75: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). ``` After: ``` » cargo run --bin ruff ../litestar/litestar ../litestar/tests Finished dev [unoptimized + debuginfo] target(s) in 0.15s Running `target/debug/ruff ../litestar/litestar ../litestar/tests` warning: Detected debug build without --no-cache. warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_bigint.py:19: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_bigint.py:65: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_bigint.py:74: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_uuid.py:22: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_uuid.py:66: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_uuid.py:75: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). ``` ## Test Plan I didn't find any existing tests with this warning. Closes astral-sh#5855

Refs astral-sh#5856

## Summary Before: ``` » ruff litestar tests --fix warning: Invalid `# noqa` directive on line 19: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on line 65: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on line 74: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on line 22: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on line 66: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on line 75: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). ``` After: ``` » cargo run --bin ruff ../litestar/litestar ../litestar/tests Finished dev [unoptimized + debuginfo] target(s) in 0.15s Running `target/debug/ruff ../litestar/litestar ../litestar/tests` warning: Detected debug build without --no-cache. warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_bigint.py:19: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_bigint.py:65: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_bigint.py:74: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_uuid.py:22: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_uuid.py:66: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_uuid.py:75: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`). ``` ## Test Plan I didn't find any existing tests with this warning. Closes #5855

Refs #5856

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `0.0.278` -> `0.0.280` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.280`](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) ### [`v0.0.279`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.279) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.278...v0.0.279)  #### What's Changed ##### Rules - \[`flake8-pyi`] Implement flake8-pyi's PYI026 by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#5844 - \[`flake8-pyi`] Implement flake8-pyi's `PYI017` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5895 - \[`flake8-pyi`] Implement flake8-pyi's `PYI036` by [@density](https://togithub.com/density) in [astral-sh/ruff#5668 - \[`flake8-pyi`] Implement flake8-pyi's `PYI041` by [@density](https://togithub.com/density) in [astral-sh/ruff#5722 - \[`flake8-use-pathlib`] Implement `os-path-getsize` and `os-path-get(a|m|c)-time` (`PTH202-205`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5835 - \[`flake8-use-pathlib`] Implement `path-constructor-default-argument` (`PTH201`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5833 - \[`pandas-vet`] Implement constant series rule (`PD101`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5802 - \[`pylint`] Implement Pylint's `consider-using-in` (`PLR1714`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5193 ##### Rule changes - \[`flake8-annotations`] Check for `Any` in other types for `ANN401` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5601 - \[`flake8-bugbear`] Add autofix for B004 by [@density](https://togithub.com/density) in [astral-sh/ruff#5788 - \[`flake8-bugbear`] Remove `B904`'s lowercase exemption by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5751 - \[`flake8-use-pathlib`] extend PTH118 with `os.sep` by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5935 - \[`pyupgrade`] Expand scope of `quoted-annotation` rule (`UP037`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5766 - \[`pyupgrade`] Extend PEP 604 rewrites to support some quoted annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5725 - \[`ruff`] Expand `RUF015` to include all expression types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5767 ##### Bug Fixes - Consider single element subscript expr for implicit optional by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5717 - Ignore `Enum`-and-`str` subclasses for slots enforcement by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5749 - Avoid removing raw strings in comparison fixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5755 - Fix nested calls to `sorted` with differing arguments by [@density](https://togithub.com/density) in [astral-sh/ruff#5761 - Use unused variable detection to power `incorrect-dict-iterator` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5763 - Include alias when formatting import-from structs by [@guillaumeLepape](https://togithub.com/guillaumeLepape) in [astral-sh/ruff#5786 - Make `lint_only` aware of the source kind by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5876 - Restore `redefined-while-unused` violations in classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5926 - Flatten nested tuples when fixing UP007 violations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5724 - Ignore Jupyter Notebooks for `--add-noqa` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5727 - Avoid checking `EXE001` and `EXE002` on WSL by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5735 - Properly group assignment targets by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#5728 - Avoid stack overflow for non-BitOr binary types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5743 - Move function visit out of `Expr::Call` branches by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5772 - \[B006] Add bytes to immutable types by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5776 - Format `SetComp` by [@lkh42t](https://togithub.com/lkh42t) in [astral-sh/ruff#5774 - Gate `runtime-import-in-type-checking-block` (`TCH004`) behind enabled flag by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5789 - perf: only compute start offset for overlong lines by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5811 - Change `pandas-use-of-dot-read-table` rule to emit only when `read_table` is used on CSV data by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5807 - Do not fix `NamedTuple` calls containing both a list of fields and keywords by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5799 - Ignore directories when collecting files to lint by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5775 - Add filename to `noqa` warnings by [@sobolevn](https://togithub.com/sobolevn) in [astral-sh/ruff#5856 - Handle io errors gracefully by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#5611 - Allow `respect_gitignore` when not in a git repo by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5937 #### New Contributors - [@eggplants](https://togithub.com/eggplants) made their first contribution in [astral-sh/ruff#5741 - [@guillaumeLepape](https://togithub.com/guillaumeLepape) made their first contribution in [astral-sh/ruff#5786 - [@odiseo0](https://togithub.com/odiseo0) made their first contribution in [astral-sh/ruff#5888 - [@DavidCain](https://togithub.com/DavidCain) made their first contribution in [astral-sh/ruff#5889 - [@LaBatata101](https://togithub.com/LaBatata101) made their first contribution in [astral-sh/ruff#5844 **Full Changelog**: astral-sh/ruff@v0.0.278...v0.0.279 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jankatins/pr-workflow-example).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.278` -> `==0.0.280` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.280`](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) ### [`v0.0.279`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.279) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.278...v0.0.279)  #### What's Changed ##### Rules - \[`flake8-pyi`] Implement flake8-pyi's PYI026 by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#5844 - \[`flake8-pyi`] Implement flake8-pyi's `PYI017` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5895 - \[`flake8-pyi`] Implement flake8-pyi's `PYI036` by [@density](https://togithub.com/density) in [astral-sh/ruff#5668 - \[`flake8-pyi`] Implement flake8-pyi's `PYI041` by [@density](https://togithub.com/density) in [astral-sh/ruff#5722 - \[`flake8-use-pathlib`] Implement `os-path-getsize` and `os-path-get(a|m|c)-time` (`PTH202-205`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5835 - \[`flake8-use-pathlib`] Implement `path-constructor-default-argument` (`PTH201`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5833 - \[`pandas-vet`] Implement constant series rule (`PD101`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5802 - \[`pylint`] Implement Pylint's `consider-using-in` (`PLR1714`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5193 ##### Rule changes - \[`flake8-annotations`] Check for `Any` in other types for `ANN401` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5601 - \[`flake8-bugbear`] Add autofix for B004 by [@density](https://togithub.com/density) in [astral-sh/ruff#5788 - \[`flake8-bugbear`] Remove `B904`'s lowercase exemption by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5751 - \[`flake8-use-pathlib`] extend PTH118 with `os.sep` by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5935 - \[`pyupgrade`] Expand scope of `quoted-annotation` rule (`UP037`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5766 - \[`pyupgrade`] Extend PEP 604 rewrites to support some quoted annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5725 - \[`ruff`] Expand `RUF015` to include all expression types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5767 ##### Bug Fixes - Consider single element subscript expr for implicit optional by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5717 - Ignore `Enum`-and-`str` subclasses for slots enforcement by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5749 - Avoid removing raw strings in comparison fixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5755 - Fix nested calls to `sorted` with differing arguments by [@density](https://togithub.com/density) in [astral-sh/ruff#5761 - Use unused variable detection to power `incorrect-dict-iterator` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5763 - Include alias when formatting import-from structs by [@guillaumeLepape](https://togithub.com/guillaumeLepape) in [astral-sh/ruff#5786 - Make `lint_only` aware of the source kind by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5876 - Restore `redefined-while-unused` violations in classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5926 - Flatten nested tuples when fixing UP007 violations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5724 - Ignore Jupyter Notebooks for `--add-noqa` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5727 - Avoid checking `EXE001` and `EXE002` on WSL by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5735 - Properly group assignment targets by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#5728 - Avoid stack overflow for non-BitOr binary types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5743 - Move function visit out of `Expr::Call` branches by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5772 - \[B006] Add bytes to immutable types by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5776 - Format `SetComp` by [@lkh42t](https://togithub.com/lkh42t) in [astral-sh/ruff#5774 - Gate `runtime-import-in-type-checking-block` (`TCH004`) behind enabled flag by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5789 - perf: only compute start offset for overlong lines by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5811 - Change `pandas-use-of-dot-read-table` rule to emit only when `read_table` is used on CSV data by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5807 - Do not fix `NamedTuple` calls containing both a list of fields and keywords by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5799 - Ignore directories when collecting files to lint by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5775 - Add filename to `noqa` warnings by [@sobolevn](https://togithub.com/sobolevn) in [astral-sh/ruff#5856 - Handle io errors gracefully by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#5611 - Allow `respect_gitignore` when not in a git repo by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5937 #### New Contributors - [@eggplants](https://togithub.com/eggplants) made their first contribution in [astral-sh/ruff#5741 - [@guillaumeLepape](https://togithub.com/guillaumeLepape) made their first contribution in [astral-sh/ruff#5786 - [@odiseo0](https://togithub.com/odiseo0) made their first contribution in [astral-sh/ruff#5888 - [@DavidCain](https://togithub.com/DavidCain) made their first contribution in [astral-sh/ruff#5889 - [@LaBatata101](https://togithub.com/LaBatata101) made their first contribution in [astral-sh/ruff#5844 **Full Changelog**: astral-sh/ruff@v0.0.278...v0.0.279 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.278` -> `==0.0.280` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.280`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.280) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280)  #### What's Changed ##### Bug Fixes - Avoid collapsing `elif` and `else` branches during import sorting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5964 **Full Changelog**: astral-sh/ruff@v0.0.279...v0.0.280 ### [`v0.0.279`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.279) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.278...v0.0.279)  #### What's Changed ##### Rules - \[`flake8-pyi`] Implement flake8-pyi's PYI026 by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#5844 - \[`flake8-pyi`] Implement flake8-pyi's `PYI017` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5895 - \[`flake8-pyi`] Implement flake8-pyi's `PYI036` by [@density](https://togithub.com/density) in [astral-sh/ruff#5668 - \[`flake8-pyi`] Implement flake8-pyi's `PYI041` by [@density](https://togithub.com/density) in [astral-sh/ruff#5722 - \[`flake8-use-pathlib`] Implement `os-path-getsize` and `os-path-get(a|m|c)-time` (`PTH202-205`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5835 - \[`flake8-use-pathlib`] Implement `path-constructor-default-argument` (`PTH201`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5833 - \[`pandas-vet`] Implement constant series rule (`PD101`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5802 - \[`pylint`] Implement Pylint's `consider-using-in` (`PLR1714`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5193 ##### Rule changes - \[`flake8-annotations`] Check for `Any` in other types for `ANN401` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5601 - \[`flake8-bugbear`] Add autofix for B004 by [@density](https://togithub.com/density) in [astral-sh/ruff#5788 - \[`flake8-bugbear`] Remove `B904`'s lowercase exemption by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5751 - \[`flake8-use-pathlib`] extend PTH118 with `os.sep` by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5935 - \[`pyupgrade`] Expand scope of `quoted-annotation` rule (`UP037`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5766 - \[`pyupgrade`] Extend PEP 604 rewrites to support some quoted annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5725 - \[`ruff`] Expand `RUF015` to include all expression types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5767 ##### Bug Fixes - Consider single element subscript expr for implicit optional by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5717 - Ignore `Enum`-and-`str` subclasses for slots enforcement by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5749 - Avoid removing raw strings in comparison fixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5755 - Fix nested calls to `sorted` with differing arguments by [@density](https://togithub.com/density) in [astral-sh/ruff#5761 - Use unused variable detection to power `incorrect-dict-iterator` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5763 - Include alias when formatting import-from structs by [@guillaumeLepape](https://togithub.com/guillaumeLepape) in [astral-sh/ruff#5786 - Make `lint_only` aware of the source kind by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5876 - Restore `redefined-while-unused` violations in classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5926 - Flatten nested tuples when fixing UP007 violations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5724 - Ignore Jupyter Notebooks for `--add-noqa` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5727 - Avoid checking `EXE001` and `EXE002` on WSL by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5735 - Properly group assignment targets by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#5728 - Avoid stack overflow for non-BitOr binary types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5743 - Move function visit out of `Expr::Call` branches by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5772 - \[B006] Add bytes to immutable types by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5776 - Format `SetComp` by [@lkh42t](https://togithub.com/lkh42t) in [astral-sh/ruff#5774 - Gate `runtime-import-in-type-checking-block` (`TCH004`) behind enabled flag by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5789 - perf: only compute start offset for overlong lines by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5811 - Change `pandas-use-of-dot-read-table` rule to emit only when `read_table` is used on CSV data by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5807 - Do not fix `NamedTuple` calls containing both a list of fields and keywords by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5799 - Ignore directories when collecting files to lint by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5775 - Add filename to `noqa` warnings by [@sobolevn](https://togithub.com/sobolevn) in [astral-sh/ruff#5856 - Handle io errors gracefully by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#5611 - Allow `respect_gitignore` when not in a git repo by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5937 #### New Contributors - [@eggplants](https://togithub.com/eggplants) made their first contribution in [astral-sh/ruff#5741 - [@guillaumeLepape](https://togithub.com/guillaumeLepape) made their first contribution in [astral-sh/ruff#5786 - [@odiseo0](https://togithub.com/odiseo0) made their first contribution in [astral-sh/ruff#5888 - [@DavidCain](https://togithub.com/DavidCain) made their first contribution in [astral-sh/ruff#5889 - [@LaBatata101](https://togithub.com/LaBatata101) made their first contribution in [astral-sh/ruff#5844 **Full Changelog**: astral-sh/ruff@v0.0.278...v0.0.279 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

sobolevn added 4 commits July 18, 2023 09:45

Add filename to noqa warnings

a24e2f5

Fix CI

a7f60d0

Fix CI

fd0633a

Fix clippy

8a18ef0

charliermarsh self-requested a review July 18, 2023 13:54

Switch order of arguments

63431ec

charliermarsh enabled auto-merge (squash) July 18, 2023 13:59

charliermarsh merged commit 0c7c81a into astral-sh:main Jul 18, 2023
15 checks passed

sobolevn added a commit to sobolevn/ruff that referenced this pull request Jul 18, 2023

Use relativize_path for noqa warnings

fdef71d

Refs astral-sh#5856

sobolevn mentioned this pull request Jul 18, 2023

Use relativize_path for noqa warnings #5867

Merged

charliermarsh pushed a commit that referenced this pull request Jul 18, 2023

Use relativize_path for noqa warnings (#5867)

cdfed3d

Refs #5856

evanrittenhouse pushed a commit to evanrittenhouse/ruff that referenced this pull request Jul 19, 2023

Use relativize_path for noqa warnings (astral-sh#5867)

3b29822

Refs astral-sh#5856

konstin pushed a commit that referenced this pull request Jul 19, 2023

Use relativize_path for noqa warnings (#5867)

d69ffb2

Refs #5856

chenrui333 mentioned this pull request Jul 21, 2023

ruff 0.0.279 Homebrew/homebrew-core#137262

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add filename to `noqa` warnings #5856

Add filename to `noqa` warnings #5856

sobolevn commented Jul 18, 2023 •

edited by zanieb

Loading

github-actions bot commented Jul 18, 2023 •

edited

Loading

charliermarsh commented Jul 18, 2023

sobolevn commented Jul 18, 2023

charliermarsh commented Jul 18, 2023

Add filename to noqa warnings #5856

Add filename to noqa warnings #5856

Conversation

sobolevn commented Jul 18, 2023 • edited by zanieb Loading

Summary

Test Plan

github-actions bot commented Jul 18, 2023 • edited Loading

PR Check Results

Ecosystem

Benchmark

Linux

Windows

charliermarsh commented Jul 18, 2023

sobolevn commented Jul 18, 2023

charliermarsh commented Jul 18, 2023

Add filename to `noqa` warnings #5856

Add filename to `noqa` warnings #5856

sobolevn commented Jul 18, 2023 •

edited by zanieb

Loading

github-actions bot commented Jul 18, 2023 •

edited

Loading