[flake8-pyi] Implement PYI041

[density]

Summary

Implements PYI041 from flake8-pyi. See original code.

This check only applies to function parameters in order to avoid issues with mypy. See PyCQA/flake8-pyi#299.

ref: #848

Test Plan

Snapshots, manual runs of flake8.

[github-actions]

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+4, -0, 0 error(s))

airflow (+1, -0)

+ airflow/decorators/__init__.pyi:106:25: PYI041 Use `float` instead of `int | float`

typeshed (+3, -0)

+ stdlib/random.pyi:49:27: PYI041 Use `float` instead of `int | float`
+ stdlib/turtle.pyi:428:16: PYI041 Use `float` instead of `int | float`
+ stdlib/turtle.pyi:429:17: PYI041 Use `float` instead of `int | float`

Rules changed: 1

Rule	Changes	Additions	Removals
PYI041	4	4	0

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.01      8.1±0.05ms     5.0 MB/sec    1.00      8.0±0.06ms     5.1 MB/sec
formatter/numpy/ctypeslib.py               1.00   1858.2±7.08µs     9.0 MB/sec    1.01   1872.8±8.54µs     8.9 MB/sec
formatter/numpy/globals.py                 1.00    207.7±0.49µs    14.2 MB/sec    1.01    210.3±2.96µs    14.0 MB/sec
formatter/pydantic/types.py                1.00      4.0±0.01ms     6.3 MB/sec    1.01      4.1±0.05ms     6.3 MB/sec
linter/all-rules/large/dataset.py          1.00     13.7±0.09ms     3.0 MB/sec    1.02     14.0±0.10ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.4±0.01ms     4.9 MB/sec    1.02      3.4±0.02ms     4.8 MB/sec
linter/all-rules/numpy/globals.py          1.03    450.3±0.70µs     6.6 MB/sec    1.00    435.6±0.84µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.1±0.05ms     4.2 MB/sec    1.00      6.1±0.03ms     4.2 MB/sec
linter/default-rules/large/dataset.py      1.00      6.7±0.02ms     6.1 MB/sec    1.03      6.9±0.03ms     5.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1450.5±5.99µs    11.5 MB/sec    1.03   1490.6±7.12µs    11.2 MB/sec
linter/default-rules/numpy/globals.py      1.00    166.8±9.37µs    17.7 MB/sec    1.01    168.7±1.60µs    17.5 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.0±0.01ms     8.5 MB/sec    1.03      3.1±0.01ms     8.3 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00     11.2±0.33ms     3.6 MB/sec    1.05     11.8±0.35ms     3.4 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.5±0.15ms     6.6 MB/sec    1.06      2.7±0.08ms     6.2 MB/sec
formatter/numpy/globals.py                 1.00   293.0±13.94µs    10.1 MB/sec    1.07   313.0±12.07µs     9.4 MB/sec
formatter/pydantic/types.py                1.00      5.5±0.23ms     4.6 MB/sec    1.05      5.8±0.16ms     4.4 MB/sec
linter/all-rules/large/dataset.py          1.04     20.7±0.66ms  2014.0 KB/sec    1.00     19.8±0.50ms     2.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      5.0±0.16ms     3.3 MB/sec    1.04      5.2±0.12ms     3.2 MB/sec
linter/all-rules/numpy/globals.py          1.00   599.2±17.94µs     4.9 MB/sec    1.07   640.2±19.01µs     4.6 MB/sec
linter/all-rules/pydantic/types.py         1.00      8.5±0.27ms     3.0 MB/sec    1.07      9.2±0.18ms     2.8 MB/sec
linter/default-rules/large/dataset.py      1.00      9.8±0.31ms     4.1 MB/sec    1.03     10.2±0.22ms     4.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.1±0.06ms     8.0 MB/sec    1.03      2.1±0.05ms     7.8 MB/sec
linter/default-rules/numpy/globals.py      1.00    253.1±9.29µs    11.7 MB/sec    1.06   267.9±11.92µs    11.0 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.4±0.15ms     5.7 MB/sec    1.03      4.6±0.12ms     5.5 MB/sec

[dhruvmanila]

Looks good!

[dhruvmanila]

nit: I don't think these rules are checked on Python (.py) files

Suggested change

	def f0(arg1: float | int) -> None:
	... # PYI041
	def f1(arg1: float, *, arg2: float | list[str] | type[bool] | complex) -> None:
	... # PYI041
	def f2(arg1: int, /, arg2: int | int | float) -> None:
	... # PYI041
	def f3(arg1: int, *args: Union[int | int | float]) -> None:
	... # PYI041
	async def f4(**kwargs: int | int | float) -> None:
	... # PYI041
	class Foo:
	def good(self, arg: int) -> None:
	...
	def bad(self, arg: int | float | complex) -> None:
	... # PYI041
	def f0(arg1: float | int) -> None:
	...
	def f1(arg1: float, *, arg2: float | list[str] | type[bool] | complex) -> None:
	...
	def f2(arg1: int, /, arg2: int | int | float) -> None:
	...
	def f3(arg1: int, *args: Union[int | int | float]) -> None:
	...
	async def f4(**kwargs: int | int | float) -> None:
	...
	class Foo:
	def good(self, arg: int) -> None:
	...
	def bad(self, arg: int | float | complex) -> None:
	...

[density]

Fixed, thanks!

[dhruvmanila]

I think we should document the limitation that this rule won't check for type aliases.

[density]

Added a comment. Thanks!