Extend PEP 604 rewrites to support some quoted annotations #5725

charliermarsh · 2023-07-13T04:11:16Z

Summary

Python doesn't allow "Foo" | None if the annotation will be evaluated at runtime (see the comments in the PR, or the semantic model documentation for more on what this means and when it is true), but it does allow it if the annotation is typing-only.

This, for example, is invalid, as Python will evaluate "Foo" | None at runtime in order to
populate the function's __annotations__:

def f(x: "Foo" | None): ...

This, however, is valid:

def f():
    x: "Foo" | None

As is this:

from __future__ import annotations

def f(x: "Foo" | None): ...

Closes #5706.

github-actions · 2023-07-13T04:24:07Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      8.1±0.06ms     5.0 MB/sec    1.01      8.1±0.07ms     5.0 MB/sec
formatter/numpy/ctypeslib.py               1.01   1872.8±3.29µs     8.9 MB/sec    1.00   1861.2±4.66µs     8.9 MB/sec
formatter/numpy/globals.py                 1.00    209.6±1.36µs    14.1 MB/sec    1.00    209.3±1.33µs    14.1 MB/sec
formatter/pydantic/types.py                1.02      4.1±0.02ms     6.3 MB/sec    1.00      4.0±0.02ms     6.4 MB/sec
linter/all-rules/large/dataset.py          1.00     14.2±0.13ms     2.9 MB/sec    1.01     14.3±0.13ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.4±0.03ms     4.8 MB/sec    1.01      3.5±0.03ms     4.8 MB/sec
linter/all-rules/numpy/globals.py          1.00    434.7±1.00µs     6.8 MB/sec    1.00    432.9±0.57µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.01      6.3±0.08ms     4.1 MB/sec    1.00      6.2±0.07ms     4.1 MB/sec
linter/default-rules/large/dataset.py      1.00      6.8±0.05ms     6.0 MB/sec    1.03      7.0±0.05ms     5.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1463.4±3.53µs    11.4 MB/sec    1.03   1502.8±2.50µs    11.1 MB/sec
linter/default-rules/numpy/globals.py      1.00    166.5±0.28µs    17.7 MB/sec    1.02    169.7±0.32µs    17.4 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.1±0.02ms     8.3 MB/sec    1.02      3.1±0.01ms     8.2 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      9.4±0.08ms     4.3 MB/sec    1.01      9.5±0.09ms     4.3 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.2±0.03ms     7.7 MB/sec    1.00      2.2±0.03ms     7.7 MB/sec
formatter/numpy/globals.py                 1.00    240.4±5.35µs    12.3 MB/sec    1.01    241.7±7.57µs    12.2 MB/sec
formatter/pydantic/types.py                1.00      4.7±0.06ms     5.5 MB/sec    1.01      4.7±0.06ms     5.4 MB/sec
linter/all-rules/large/dataset.py          1.01     16.0±0.37ms     2.5 MB/sec    1.00     15.8±0.25ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.1±0.04ms     4.0 MB/sec    1.00      4.1±0.07ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.00   499.7±10.03µs     5.9 MB/sec    1.00    499.5±8.00µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.0±0.05ms     3.6 MB/sec    1.00      7.0±0.07ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.00      8.0±0.06ms     5.1 MB/sec    1.00      8.1±0.09ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1702.5±19.65µs     9.8 MB/sec    1.01  1713.9±24.80µs     9.7 MB/sec
linter/default-rules/numpy/globals.py      1.00    199.1±2.94µs    14.8 MB/sec    1.00    199.5±2.48µs    14.8 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.6±0.03ms     7.1 MB/sec    1.00      3.6±0.04ms     7.1 MB/sec

MichaReiser · 2023-07-13T06:35:00Z

crates/ruff_python_semantic/src/analyze/typing.rs

+    if quoted_annotation(slice) {
+        if semantic.execution_context().is_runtime() {


You love your nested ifs ;)

and i thought i'm the one looking at SIM102 too long ;)

I’m sorry, it’s just how my brain works!

## Summary Python doesn't allow `"Foo" | None` if the annotation will be evaluated at runtime (see the comments in the PR, or the semantic model documentation for more on what this means and when it is true), but it _does_ allow it if the annotation is typing-only. This, for example, is invalid, as Python will evaluate `"Foo" | None` at runtime in order to populate the function's `__annotations__`: ```python def f(x: "Foo" | None): ... ``` This, however, is valid: ```python def f(): x: "Foo" | None ``` As is this: ```python from __future__ import annotations def f(x: "Foo" | None): ... ``` Closes #5706.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `0.0.278` -> `0.0.280` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.280`](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) ### [`v0.0.279`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.279) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.278...v0.0.279)  #### What's Changed ##### Rules - \[`flake8-pyi`] Implement flake8-pyi's PYI026 by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#5844 - \[`flake8-pyi`] Implement flake8-pyi's `PYI017` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5895 - \[`flake8-pyi`] Implement flake8-pyi's `PYI036` by [@density](https://togithub.com/density) in [astral-sh/ruff#5668 - \[`flake8-pyi`] Implement flake8-pyi's `PYI041` by [@density](https://togithub.com/density) in [astral-sh/ruff#5722 - \[`flake8-use-pathlib`] Implement `os-path-getsize` and `os-path-get(a|m|c)-time` (`PTH202-205`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5835 - \[`flake8-use-pathlib`] Implement `path-constructor-default-argument` (`PTH201`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5833 - \[`pandas-vet`] Implement constant series rule (`PD101`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5802 - \[`pylint`] Implement Pylint's `consider-using-in` (`PLR1714`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5193 ##### Rule changes - \[`flake8-annotations`] Check for `Any` in other types for `ANN401` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5601 - \[`flake8-bugbear`] Add autofix for B004 by [@density](https://togithub.com/density) in [astral-sh/ruff#5788 - \[`flake8-bugbear`] Remove `B904`'s lowercase exemption by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5751 - \[`flake8-use-pathlib`] extend PTH118 with `os.sep` by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5935 - \[`pyupgrade`] Expand scope of `quoted-annotation` rule (`UP037`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5766 - \[`pyupgrade`] Extend PEP 604 rewrites to support some quoted annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5725 - \[`ruff`] Expand `RUF015` to include all expression types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5767 ##### Bug Fixes - Consider single element subscript expr for implicit optional by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5717 - Ignore `Enum`-and-`str` subclasses for slots enforcement by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5749 - Avoid removing raw strings in comparison fixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5755 - Fix nested calls to `sorted` with differing arguments by [@density](https://togithub.com/density) in [astral-sh/ruff#5761 - Use unused variable detection to power `incorrect-dict-iterator` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5763 - Include alias when formatting import-from structs by [@guillaumeLepape](https://togithub.com/guillaumeLepape) in [astral-sh/ruff#5786 - Make `lint_only` aware of the source kind by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5876 - Restore `redefined-while-unused` violations in classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5926 - Flatten nested tuples when fixing UP007 violations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5724 - Ignore Jupyter Notebooks for `--add-noqa` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5727 - Avoid checking `EXE001` and `EXE002` on WSL by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5735 - Properly group assignment targets by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#5728 - Avoid stack overflow for non-BitOr binary types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5743 - Move function visit out of `Expr::Call` branches by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5772 - \[B006] Add bytes to immutable types by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5776 - Format `SetComp` by [@lkh42t](https://togithub.com/lkh42t) in [astral-sh/ruff#5774 - Gate `runtime-import-in-type-checking-block` (`TCH004`) behind enabled flag by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5789 - perf: only compute start offset for overlong lines by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5811 - Change `pandas-use-of-dot-read-table` rule to emit only when `read_table` is used on CSV data by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5807 - Do not fix `NamedTuple` calls containing both a list of fields and keywords by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5799 - Ignore directories when collecting files to lint by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5775 - Add filename to `noqa` warnings by [@sobolevn](https://togithub.com/sobolevn) in [astral-sh/ruff#5856 - Handle io errors gracefully by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#5611 - Allow `respect_gitignore` when not in a git repo by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5937 #### New Contributors - [@eggplants](https://togithub.com/eggplants) made their first contribution in [astral-sh/ruff#5741 - [@guillaumeLepape](https://togithub.com/guillaumeLepape) made their first contribution in [astral-sh/ruff#5786 - [@odiseo0](https://togithub.com/odiseo0) made their first contribution in [astral-sh/ruff#5888 - [@DavidCain](https://togithub.com/DavidCain) made their first contribution in [astral-sh/ruff#5889 - [@LaBatata101](https://togithub.com/LaBatata101) made their first contribution in [astral-sh/ruff#5844 **Full Changelog**: astral-sh/ruff@v0.0.278...v0.0.279 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jankatins/pr-workflow-example).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.278` -> `==0.0.280` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.280`](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280) ### [`v0.0.279`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.279) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.278...v0.0.279)  #### What's Changed ##### Rules - \[`flake8-pyi`] Implement flake8-pyi's PYI026 by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#5844 - \[`flake8-pyi`] Implement flake8-pyi's `PYI017` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5895 - \[`flake8-pyi`] Implement flake8-pyi's `PYI036` by [@density](https://togithub.com/density) in [astral-sh/ruff#5668 - \[`flake8-pyi`] Implement flake8-pyi's `PYI041` by [@density](https://togithub.com/density) in [astral-sh/ruff#5722 - \[`flake8-use-pathlib`] Implement `os-path-getsize` and `os-path-get(a|m|c)-time` (`PTH202-205`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5835 - \[`flake8-use-pathlib`] Implement `path-constructor-default-argument` (`PTH201`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5833 - \[`pandas-vet`] Implement constant series rule (`PD101`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5802 - \[`pylint`] Implement Pylint's `consider-using-in` (`PLR1714`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5193 ##### Rule changes - \[`flake8-annotations`] Check for `Any` in other types for `ANN401` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5601 - \[`flake8-bugbear`] Add autofix for B004 by [@density](https://togithub.com/density) in [astral-sh/ruff#5788 - \[`flake8-bugbear`] Remove `B904`'s lowercase exemption by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5751 - \[`flake8-use-pathlib`] extend PTH118 with `os.sep` by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5935 - \[`pyupgrade`] Expand scope of `quoted-annotation` rule (`UP037`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5766 - \[`pyupgrade`] Extend PEP 604 rewrites to support some quoted annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5725 - \[`ruff`] Expand `RUF015` to include all expression types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5767 ##### Bug Fixes - Consider single element subscript expr for implicit optional by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5717 - Ignore `Enum`-and-`str` subclasses for slots enforcement by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5749 - Avoid removing raw strings in comparison fixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5755 - Fix nested calls to `sorted` with differing arguments by [@density](https://togithub.com/density) in [astral-sh/ruff#5761 - Use unused variable detection to power `incorrect-dict-iterator` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5763 - Include alias when formatting import-from structs by [@guillaumeLepape](https://togithub.com/guillaumeLepape) in [astral-sh/ruff#5786 - Make `lint_only` aware of the source kind by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5876 - Restore `redefined-while-unused` violations in classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5926 - Flatten nested tuples when fixing UP007 violations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5724 - Ignore Jupyter Notebooks for `--add-noqa` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5727 - Avoid checking `EXE001` and `EXE002` on WSL by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5735 - Properly group assignment targets by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#5728 - Avoid stack overflow for non-BitOr binary types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5743 - Move function visit out of `Expr::Call` branches by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5772 - \[B006] Add bytes to immutable types by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5776 - Format `SetComp` by [@lkh42t](https://togithub.com/lkh42t) in [astral-sh/ruff#5774 - Gate `runtime-import-in-type-checking-block` (`TCH004`) behind enabled flag by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5789 - perf: only compute start offset for overlong lines by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5811 - Change `pandas-use-of-dot-read-table` rule to emit only when `read_table` is used on CSV data by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5807 - Do not fix `NamedTuple` calls containing both a list of fields and keywords by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5799 - Ignore directories when collecting files to lint by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5775 - Add filename to `noqa` warnings by [@sobolevn](https://togithub.com/sobolevn) in [astral-sh/ruff#5856 - Handle io errors gracefully by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#5611 - Allow `respect_gitignore` when not in a git repo by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5937 #### New Contributors - [@eggplants](https://togithub.com/eggplants) made their first contribution in [astral-sh/ruff#5741 - [@guillaumeLepape](https://togithub.com/guillaumeLepape) made their first contribution in [astral-sh/ruff#5786 - [@odiseo0](https://togithub.com/odiseo0) made their first contribution in [astral-sh/ruff#5888 - [@DavidCain](https://togithub.com/DavidCain) made their first contribution in [astral-sh/ruff#5889 - [@LaBatata101](https://togithub.com/LaBatata101) made their first contribution in [astral-sh/ruff#5844 **Full Changelog**: astral-sh/ruff@v0.0.278...v0.0.279 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://togithub.com/astral-sh/ruff), [changelog](https://togithub.com/astral-sh/ruff/releases)) | `==0.0.278` -> `==0.0.280` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/ruff/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.0.278/0.0.280?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.280`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.280) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.279...v0.0.280)  #### What's Changed ##### Bug Fixes - Avoid collapsing `elif` and `else` branches during import sorting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5964 **Full Changelog**: astral-sh/ruff@v0.0.279...v0.0.280 ### [`v0.0.279`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.279) [Compare Source](https://togithub.com/astral-sh/ruff/compare/v0.0.278...v0.0.279)  #### What's Changed ##### Rules - \[`flake8-pyi`] Implement flake8-pyi's PYI026 by [@LaBatata101](https://togithub.com/LaBatata101) in [astral-sh/ruff#5844 - \[`flake8-pyi`] Implement flake8-pyi's `PYI017` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#5895 - \[`flake8-pyi`] Implement flake8-pyi's `PYI036` by [@density](https://togithub.com/density) in [astral-sh/ruff#5668 - \[`flake8-pyi`] Implement flake8-pyi's `PYI041` by [@density](https://togithub.com/density) in [astral-sh/ruff#5722 - \[`flake8-use-pathlib`] Implement `os-path-getsize` and `os-path-get(a|m|c)-time` (`PTH202-205`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5835 - \[`flake8-use-pathlib`] Implement `path-constructor-default-argument` (`PTH201`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5833 - \[`pandas-vet`] Implement constant series rule (`PD101`) by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5802 - \[`pylint`] Implement Pylint's `consider-using-in` (`PLR1714`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5193 ##### Rule changes - \[`flake8-annotations`] Check for `Any` in other types for `ANN401` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5601 - \[`flake8-bugbear`] Add autofix for B004 by [@density](https://togithub.com/density) in [astral-sh/ruff#5788 - \[`flake8-bugbear`] Remove `B904`'s lowercase exemption by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5751 - \[`flake8-use-pathlib`] extend PTH118 with `os.sep` by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5935 - \[`pyupgrade`] Expand scope of `quoted-annotation` rule (`UP037`) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5766 - \[`pyupgrade`] Extend PEP 604 rewrites to support some quoted annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5725 - \[`ruff`] Expand `RUF015` to include all expression types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5767 ##### Bug Fixes - Consider single element subscript expr for implicit optional by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5717 - Ignore `Enum`-and-`str` subclasses for slots enforcement by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5749 - Avoid removing raw strings in comparison fixes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5755 - Fix nested calls to `sorted` with differing arguments by [@density](https://togithub.com/density) in [astral-sh/ruff#5761 - Use unused variable detection to power `incorrect-dict-iterator` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5763 - Include alias when formatting import-from structs by [@guillaumeLepape](https://togithub.com/guillaumeLepape) in [astral-sh/ruff#5786 - Make `lint_only` aware of the source kind by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5876 - Restore `redefined-while-unused` violations in classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5926 - Flatten nested tuples when fixing UP007 violations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5724 - Ignore Jupyter Notebooks for `--add-noqa` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5727 - Avoid checking `EXE001` and `EXE002` on WSL by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5735 - Properly group assignment targets by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#5728 - Avoid stack overflow for non-BitOr binary types by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5743 - Move function visit out of `Expr::Call` branches by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5772 - \[B006] Add bytes to immutable types by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5776 - Format `SetComp` by [@lkh42t](https://togithub.com/lkh42t) in [astral-sh/ruff#5774 - Gate `runtime-import-in-type-checking-block` (`TCH004`) behind enabled flag by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#5789 - perf: only compute start offset for overlong lines by [@sbrugman](https://togithub.com/sbrugman) in [astral-sh/ruff#5811 - Change `pandas-use-of-dot-read-table` rule to emit only when `read_table` is used on CSV data by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#5807 - Do not fix `NamedTuple` calls containing both a list of fields and keywords by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5799 - Ignore directories when collecting files to lint by [@harupy](https://togithub.com/harupy) in [astral-sh/ruff#5775 - Add filename to `noqa` warnings by [@sobolevn](https://togithub.com/sobolevn) in [astral-sh/ruff#5856 - Handle io errors gracefully by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#5611 - Allow `respect_gitignore` when not in a git repo by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#5937 #### New Contributors - [@eggplants](https://togithub.com/eggplants) made their first contribution in [astral-sh/ruff#5741 - [@guillaumeLepape](https://togithub.com/guillaumeLepape) made their first contribution in [astral-sh/ruff#5786 - [@odiseo0](https://togithub.com/odiseo0) made their first contribution in [astral-sh/ruff#5888 - [@DavidCain](https://togithub.com/DavidCain) made their first contribution in [astral-sh/ruff#5889 - [@LaBatata101](https://togithub.com/LaBatata101) made their first contribution in [astral-sh/ruff#5844 **Full Changelog**: astral-sh/ruff@v0.0.278...v0.0.279 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Base automatically changed from charlie/flat to main July 13, 2023 04:11

charliermarsh added 2 commits July 13, 2023 00:13

Support fixing string in option

93118db

Change in analyze instead

2f3abe7

charliermarsh force-pushed the charlie/string-option branch from a976d66 to 2f3abe7 Compare July 13, 2023 04:13

dhruvmanila approved these changes Jul 13, 2023

View reviewed changes

MichaReiser approved these changes Jul 13, 2023

View reviewed changes

charliermarsh merged commit 932c9a4 into main Jul 13, 2023
16 checks passed

charliermarsh deleted the charlie/string-option branch July 13, 2023 11:34

charliermarsh mentioned this pull request Jul 14, 2023

UP007 - Bug for Unions and Optional with Quotes Inside Brackets #5756

Closed

chenrui333 mentioned this pull request Jul 21, 2023

ruff 0.0.279 Homebrew/homebrew-core#137262

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend PEP 604 rewrites to support some quoted annotations #5725

Extend PEP 604 rewrites to support some quoted annotations #5725

charliermarsh commented Jul 13, 2023

github-actions bot commented Jul 13, 2023 •

edited

Loading

MichaReiser Jul 13, 2023

konstin Jul 13, 2023

charliermarsh Jul 13, 2023

		if quoted_annotation(slice) {
		if semantic.execution_context().is_runtime() {

Extend PEP 604 rewrites to support some quoted annotations #5725

Extend PEP 604 rewrites to support some quoted annotations #5725

Conversation

charliermarsh commented Jul 13, 2023

Summary

github-actions bot commented Jul 13, 2023 • edited Loading

PR Check Results

Ecosystem

Benchmark

Linux

Windows

MichaReiser Jul 13, 2023

Choose a reason for hiding this comment

konstin Jul 13, 2023

Choose a reason for hiding this comment

charliermarsh Jul 13, 2023

Choose a reason for hiding this comment

github-actions bot commented Jul 13, 2023 •

edited

Loading