Revise and update workspace build configuration #475
Conversation
|
@tonyarnold: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
tonyarnold
force-pushed
the
fix/build-configuration
branch
2 times, most recently
from
b0c7044
to
417d7cd
Compare
|
Thanks a lot for working on this! Configuring framework builds with support for multiple platforms in Xcode is a pain, so I'm really happy you went through the trouble of extracting settings into It seems the tests for |
|
Yeah, I'm a bit puzzled by that. It looks like the cache dependent tests are looking for a GraphQL server running on localhost at port 8080. I'll see if there's anything in the project's documentation about it. |
|
That's the |
tonyarnold
force-pushed
the
fix/build-configuration
branch
4 times, most recently
from
0ae7756
to
22e090d
Compare
|
Ahh yes, I'd not wired up some of the test support frameworks as universal. Let's see how this latest build goes - it's all passing locally for both macOS and iOS now. |
…hared where appropriate
…to the Xcode project file # Conflicts: # ApolloWebSocket.xcodeproj/project.pbxproj # Conflicts: # ApolloSQLite.xcodeproj/project.pbxproj
tonyarnold
force-pushed
the
fix/build-configuration
branch
from
22e090d
to
c646a8e
Compare
tonyarnold
force-pushed
the
fix/build-configuration
branch
from
c646a8e
to
5c1b3da
Compare
|
Because of the way the |
|
Oh, good find! Let's wait until Xcode 10.2 is released then. The |
|
I did check on the upstream dependencies, and it doesn't look like there have been any releases since the ones the project already uses. 👍 |
|
@tonyarnold Now that Xcode 10.2 has been released, have you had a chance to see if that solves the build issues with |
|
Everything passes for me here locally - it's really going to come down to Travis CI updating their environments. The project also specifies a bunch of iOS simulator versions that weren't installed in the 10.2 beta environment - once they're in the release, this should be 👍 to merge/release. |
|
@tonyarnold I reran the tests, hoping Travis would have updated their image. I'm seeing some missinng iOS simulator version errors though, so we'll probably have to wait a little longer. |
|
Yeah, I checked earlier today - the |
|
@martijnwalraven @tonyarnold I wonder if the issue with simulator is the same I had with Bitrise yesterday. Seems like |
|
Would you folks mind keeping at least Xcode 10.1 in .travis.yml as well, and even 10.0 if possible? Given how many projects break with 10.2, I imagine its adoption is going to be slow and a lot of people will stay with 10.1 and earlier for long time. I'd appreciate if compatibility of Apollo with older versions is preserved and tested. |
|
@tonyarnold Thank you so much for working on this! |
|
@MaxDesiatov I see where you're coming from, but let's discuss that in a separate issue. Our This hasn't been an issue before, but have there been more breaking changes in Xcode 10.2? Is the concern that it only supports Swift 4 and up? It also seems right now other projects (like Alamofire) don't test on multiple Xcode versions either, but that could change when people run into problems of course. |
|
@martijnwalraven you’re very welcome. I thought the project was dead, but obviously not! Ping me if there’s anything wrong with the work. I’m happy to help out. I also have a branch that updates to the latest version of apollo-client - would that be useful too? |
|
@tonyarnold No, the project isn't dead, we are in fact hiring for a full-time mobile position. But I've taken on other responsibilities within the company at the beginning of last year, and haven't been able to give this project the attention it deserves. What do you mean by updating to the latest version of |
|
Sorry, I'm new to the various tools - I meant |
|
@tonyarnold Ah, yes, that makes sense. Unfortunately, there have been breaking changes in |
|
Hi @tonyarnold, I've been trying to integrate Apollo to our tvOS project but our project is still in Swift 4.2. So, I forked v0.9.5, and apply your commit for the configs but after doing so, each time Carthage tries to compile it doesn't found the reference to the framework SQLite in the ApolloSQLite project. I'd like to know if I need to do something else to make it compile for tvOS that I can apply to the fork? It's a matter of urgency if you can help on this since we need GraphQL implementation ASAP. Thanks for all the help you can give me. |
|
@claudiogomezGL there were a lot of changes in this PR - I'm not really sure trying to separate them out this way will work. Can you not update to 0.10.x? |
|
Hi @tonyarnold, our project is using swift 5 and I am trying to integrate the latest version 0.10.1 of Apollo using Carthage. The problem is same as others are facing that it is failing to find the reference to SQLite and I need to integrate it as soon as possible due to limited time to deliver the project. The project is already using Carthage so we would have to use Carthage as well. Following is the log related to the failure. Can you please help me?
|
I have been having trouble getting various pieces of Apollo to build for macOS since I started using it, and from what I can see, it all comes down to how the build has been configured.
This PR aims to do a few things:
.pbxprojfiles so that they can be shared between the various projects and targets in the workspace.pbxprojfiles.swiftcversions 4.2 and 5.0).I know there's a fair bit in this PR, but it should simplify maintenance.
This fixes the following issues: