Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module compiled with Swift 4.2.1 cannot be imported by the Swift 5.0 compiler #478

Closed
jordanhbuiltbyhq opened this issue Mar 25, 2019 · 10 comments

Comments

@jordanhbuiltbyhq
Copy link

Please add support for Swift 5 with Xcode 10.2 :)

@uypanha
Copy link

uypanha commented Mar 26, 2019

Got the same problem..

@aBuder
Copy link

aBuder commented Mar 26, 2019

Hey I found an workaround, if you use Cocoa pods try this.
The current master branch has fix, but is not released. See also the current commit

40b8186

pod 'Apollo', :inhibit_warnings => true, :git => 'https://github.com/apollographql/apollo-ios.git', :branch => 'master'

@uypanha
Copy link

uypanha commented Mar 26, 2019

Thanks, will update my pod.

@SRozhina
Copy link

SRozhina commented Mar 26, 2019

@aBuder , I cannot use pod 'Apollo', :inhibit_warnings => true, :git => 'https://github.com/apollographql/apollo-ios.git', :branch => 'master' because of using Apollo in custom module with Cocoapods. There is no way to add git path dependency to podspec.

@indevizible
Copy link

it seems still error after execute script.
Apollo.framework/check-and-run-apollo-cli.sh: line 71: npm: command not found

@benjamin-es-hall
Copy link

#427 seems to have fixed this on 30th Jan but no tagged release has occurred since then so will have to point to master in podfile until then.

@mike-marcacci
Copy link

mike-marcacci commented Mar 28, 2019

Is there any known workaround for those of us using Carthage? Just upgraded Xcode on total autopilot 🤦🏻‍♂️

@ernesto
Copy link

ernesto commented Mar 28, 2019

@SRozhina You can work with custom modules using the s.dependecy 'Apollo' on .podspec and overriding Apollo framework on the app podfile:

  # Internal Libraries
  pod 'ProjectCore', path: '../project-ios-sdk'
    
  # Network
  pod 'Apollo', :inhibit_warnings => true, :git => 'https://github.com/apollographql/apollo-ios.git', :branch => 'master'

@mike-marcacci
Copy link

OK, well... it took me WAY too long to figure this out, but I ended up simply going into the Carthage/Checkouts/apollo-ios directory, pulling, and building. I ended up using #475 instead of master.

Also make a note NOT to run carthage update, as it will upgrade to an incompatible version of Starscream and you'll chase your tail for a bit trying to get the build to work.

@martijnwalraven
Copy link
Contributor

This should be fixed in 0.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants