Update ApolloSQLite project to Swift 4.0 #458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JosephDuffy: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
I think this needs to be merged ASAP, from Xcode 10.2 and forward Swift 3 is no longer supported and Swift 4 is the lowest supported version. That means that without this merge, all Carthage builds will fail from today and forward (given you use the latests tools). Ive also opened my own PR (#484) for this but I changed the Swift compiler to Swift 5 instead. From my side it doesn't really matter if this PR or mine gets merged since both will work with Xcode 10.2. I just want my Carthage builds to not fail. |
|
Closing this in favor of #475. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was an update that enables support for Xcode 10.2 (with the Swift 5 compiler) but this did not work for Carthage because the project itself was still using Swift 3.0.
This PR updates the project to use Swift 4.0