[SEDONA-244][SEDONA-246] R align spark_read/write functions #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DESCRIPTION cleanup: bump to dev version .9000, move dplyr to Suggests (never imported, a dependency of sparklyr anyway)
Fixes to documentation
More geoparquet tests (copied from scala tests)
Create functions Tests to read/write (based on java tests)
Some read and RS functions tests
Co-authored-by: zzs-wherobots <zzs-wherobots@ZongsideMac-Studio.local> Co-authored-by: Zongsi Zhang <zongsi@Zongsis-MacBook-Pro.local>
Adding test on multi-geom geoparquet
Using lifecycle (switch to markdown documentation) Soft deprecation warning for typed RDD functions
Fixed RS tests
Tweaks to tests
Fix arguments propagation for spark_write_geoparquet
Change way to count files in geotiff test
Changed test to accomodate bug in Spark 3.2.1 (can't reuse registered view names)
jiayuasu
requested changes
Feb 28, 2023
jiayuasu
changed the title
|
Also, man pages have so far not been committed to git. Which means i) someone needs to run BTW, the absence of man pages is the reason for one of the warnings in the GH Actions ("Warning: Undocumented code objects:" at the "Check" phase) |
jiayuasu
approved these changes
Feb 28, 2023
|
Can you create a separate PR to upload the man page? I think this PR is ready to go. |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/projects/SEDONA/issues/SEDONA-244
https://issues.apache.org/jira/projects/SEDONA/issues/SEDONA-246
What changes were proposed in this PR?
In the R package:
How was this patch tested?
Translated Scala tests for geoparquet and geotiff
Did this PR include necessary documentation updates?
R documentation only