[SEDONA-235] Integrate S2, add ST_S2CellIDs #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zongsizhang
force-pushed
the
feature/google-s2
branch
from
385b427
to
d9d06a8
Compare
zongsizhang
changed the title
Kimahriman
reviewed
Feb 12, 2023
common/src/main/java/org/apache/sedona/common/utils/GeomUtils.java
Outdated
Show resolved
Hide resolved
jiayuasu
requested changes
Feb 12, 2023
sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala
Show resolved
Hide resolved
|
@jiayuasu do you know where is this error from? |
zongsizhang
force-pushed
the
feature/google-s2
branch
2 times, most recently
from
cc6c029
to
b137832
Compare
jiayuasu
requested changes
Feb 13, 2023
sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala
Outdated
Show resolved
Hide resolved
@zongsizhang Sedona R CI is currently failing due to some unknown reason on the dependencies used in Sedona R module. We need our R maintainer to investigate this issue. Please ignore it for now. |
zongsizhang
force-pushed
the
feature/google-s2
branch
5 times, most recently
from
dbfc075
to
ac00006
Compare
zongsizhang
force-pushed
the
feature/google-s2
branch
from
cbd4a3b
to
f56df9d
Compare
zongsizhang
changed the title
jiayuasu
requested changes
Feb 20, 2023
| @@ -1101,6 +1101,30 @@ Result: | |||
| +---------------------------------------------------------------+ | |||
| ``` | |||
|
|
|||
| ## ST_S2CellIDs | |||
There was a problem hiding this comment.
Please also add this function to Sedona Flink doc.
jiayuasu
approved these changes
Feb 20, 2023
gregleleu
pushed a commit
to gregleleu/sedona
that referenced
this pull request
Feb 27, 2023
Co-authored-by: zzs-wherobots <zzs-wherobots@ZongsideMac-Studio.local> Co-authored-by: Zongsi Zhang <zongsi@Zongsis-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Add integration with Google S2 into Common https://s2geometry.io/
Add function to cover a geometry with s2Cells and return the corresponding cellIds.
Add spark core and sql functions to generate S2Cells from gemetry.
How was this patch tested?
Add many unit tests in common, sql, flink, and python module
Did this PR include necessary documentation updates?