-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-251] Add raster type to Sedona #773
Conversation
Martin, thanks for this great contribution! Your insights are always helpful to this community! I am Ok with this major change to Sedona Raster module. I think this will make everything easier in Sedona raster. A few more questions:
@kanchanchy Kanchan, downstream projects such as GeoTorchAI (https://github.com/DataSystemsLab/GeoTorchAI) heavily depends on Sedona raster funcs. What are the most important RS functions that are used by GeoTorchAI? |
Thank you @jiayuasu !
|
Hi @jiayuasu, some of the important functions used by GeoTorchAI are listed below: |
Thanks for the feedback @kanchanchy! I don’t see a need to break any of the existing api:s. Where it makes sense, some of the current RS functions could be extended to support both raster and arrays of double. Just like ST_GeomFromWKB supports both binary and string input. The way I see it is that the new raster type would only add new functionality, not remove or break any existing api. |
@umartin Thanks, Martin. I will merge this PR and let's start the discussion in the mailing list :-) BTW, maybe I should add the new geotools dependency to https://github.com/jiayuasu/geotools-wrapper? |
Yes, you're right, geotools-wrapper should be updated too. I also noticed that Sedona and geotools-wrapper are on different geotools versions. I ran tests locally with geotools 28.2 and they all passed. Maybe should upgrade both Sedona and geotools-wrapper to 28.2? |
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject
.What changes were proposed in this PR?
This PR adds a raster type to Sedona and some basic functions using the raster type.
How was this patch tested?
Unit tests added
Did this PR include necessary documentation updates?