Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Update OpenTelemetry receiver endpoint in integration test #22998

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

dragosvictor
Copy link
Contributor

@dragosvictor dragosvictor commented Jul 3, 2024

Fixes #22995

Motivation

OpenTelemetry integration tests are broken due to an upstream change in the OTel receiver. The receiver had a breaking change in v0.104.0, where the listener binds to localhost unless otherwise instructed (ref).

Modifications

Bind the receiver to 0.0.0.0:4317 for the integration tests.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as org.apache.pulsar.tests.integration.metrics.OpenTelemetrySanityTest#testOpenTelemetryMetricsOtlpExport

Does this pull request potentially affect one of the following parts:

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@dragosvictor dragosvictor marked this pull request as ready for review July 3, 2024 15:59
Copy link

github-actions bot commented Jul 3, 2024

@dragosvictor Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jul 3, 2024
@shibd shibd closed this Jul 3, 2024
@shibd shibd reopened this Jul 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.43%. Comparing base (bbc6224) to head (b9c5757).
Report is 431 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22998      +/-   ##
============================================
- Coverage     73.57%   73.43%   -0.15%     
- Complexity    32624    32964     +340     
============================================
  Files          1877     1908      +31     
  Lines        139502   142996    +3494     
  Branches      15299    15587     +288     
============================================
+ Hits         102638   105006    +2368     
- Misses        28908    29973    +1065     
- Partials       7956     8017      +61     
Flag Coverage Δ
inttests 27.54% <ø> (+2.95%) ⬆️
systests 24.75% <ø> (+0.43%) ⬆️
unittests 72.45% <ø> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 485 files with indirect coverage changes

@shibd shibd merged commit e4390d3 into apache:master Jul 3, 2024
78 of 82 checks passed
@dragosvictor dragosvictor deleted the fix-otel-integration-test branch July 3, 2024 20:09
@heesung-sn heesung-sn added this to the 3.4.0 milestone Jul 3, 2024
heesung-sn pushed a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[master branch] failed-test: OpenTelemetrySanityTest.testOpenTelemetryMetricsOtlpExport
4 participants