[fix][broker] PulsarStandalone started with error if --stream-storage-port is not 4181 #22993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dlg99 Can you review this pr？Thanks. |
nodece
approved these changes
Jul 3, 2024
|
/pulsarbot rerun-failure-checks |
|
@nodece |
…-port is not 4181
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22993 +/- ##
============================================
- Coverage 73.57% 73.42% -0.15%
- Complexity 32624 32989 +365
============================================
Files 1877 1912 +35
Lines 139502 143195 +3693
Branches 15299 15590 +291
============================================
+ Hits 102638 105148 +2510
- Misses 28908 30022 +1114
- Partials 7956 8025 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nodece
added
type/bug
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 10, 2024
…-port is not 4181 (apache#22993) (cherry picked from commit 17e3f86) (cherry picked from commit 0753a2c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 15, 2024
…-port is not 4181 (apache#22993) (cherry picked from commit 17e3f86) (cherry picked from commit 0753a2c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #22992
Modifications
Replace hard coded port with
streamStoragePortfield inLocalBookkeeperEnsemble.Verifying this change
Make sure that the change passes the CI checks.
This change added tests and can also be verified with command
PULSAR_STANDALONE_USE_ZOOKEEPER=1 bin/pulsar standalone --stream-storage-port 4182Does this pull request potentially affect one of the following parts:
NO
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: zhouyifan279#1